[breaking change] update deps#35
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesSpezi dependency consolidation and localized study metadata
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Package.swift`:
- Around line 42-47: The MHCStudyDefinitionExporter target's dependencies array
is missing three required Spezi products that are imported by the target. Add
the following three product dependencies to the dependencies array in
Package.swift: .product(name: "SpeziFoundation", package: "Spezi"),
.product(name: "SpeziHealthKit", package: "Spezi"), and .product(name:
"SpeziScheduler", package: "Spezi"). These products must be declared in the same
format as the existing Spezi products in the dependencies list to ensure the
target can access the imported modules and compile successfully.
In `@Sources/MHCStudyDefinitionExporter/Study.swift`:
- Around line 43-49: The explanationText property in the metadata initialization
for the Study definition is set to an empty dictionary, which violates Spezi 0.2
requirements that mandate at least one localization entry in localized
dictionaries. Replace the empty dictionary in explanationText with at least one
language entry following the same pattern as shortExplanationText, using the
format [.enUS: "descriptive text"] to provide localized content for the UI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3ae0d055-4064-4b3c-9cab-65c8de1d159f
📒 Files selected for processing (2)
Package.swiftSources/MHCStudyDefinitionExporter/Study.swift
PSchmiedmayer
left a comment
There was a problem hiding this comment.
Generally happy to merge, we should just ensure that we don't push this into production before we don't have the "backup loading" iOS version released to the App Store.
I think we should we disable the GitHub Action that does releases to Prod temporarily here as part of the PR to avoid any pushes there.
From my understanding, it should work if that release is not published:
-
Before we release here:
a) App version currently in the App Store will still pickup the definitions from the bucket
b)App version to be published will fall back to the built-in version as it fails to old the old study bundle version. -
Once we release here:
a) App version currently in the App Store will fail on new install and will prompt the user to update the app; existing install will continue to work, but not pick up any updates. First part should never happen as the new app version would be released so basically all fine ...
b) App version to be published will work great as it will pick up the new version from the bucket (and even if that would fail, it would have the locally bundled backup).
[breaking change] update deps
♻️ Current situation & Problem
updates Spezi to the new repo; as part of this we also update from what used to be SpeziStudy 0.1.x to what used to be SpeziStudy 0.2.x
⚙️ Release Notes
📚 Documentation
n/a
✅ Testing
n/a
Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:
Summary by CodeRabbit