Skip to content

[breaking change] update deps#35

Merged
lukaskollmer merged 6 commits into
mainfrom
lukas/update-deps
Jun 25, 2026
Merged

[breaking change] update deps#35
lukaskollmer merged 6 commits into
mainfrom
lukas/update-deps

Conversation

@lukaskollmer

@lukaskollmer lukaskollmer commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

[breaking change] update deps

♻️ Current situation & Problem

updates Spezi to the new repo; as part of this we also update from what used to be SpeziStudy 0.1.x to what used to be SpeziStudy 0.2.x

⚙️ Release Notes

  • updated dependencies to point to new Spezi repo

📚 Documentation

n/a

✅ Testing

n/a

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Summary by CodeRabbit

  • New Features
    • Added/extended localization for study metadata, including updated localized titles, explanations, and short text, with the study revision bumped to 41.
  • Chores
    • Updated supported platforms; visionOS support was removed.
    • Streamlined package dependencies by switching to the Spezi package and updating which products targets reference.
    • Adjusted concurrency isolation settings for the exporter library and CLI targets.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 995ecf66-7c18-43fc-b576-bf564a5e3acb

📥 Commits

Reviewing files that changed from the base of the PR and between 0dd1f59 and a188696.

📒 Files selected for processing (1)
  • Sources/MHCStudyDefinitionExporter/Study.swift

📝 Walkthrough

Walkthrough

Package.swift removes visionOS support and rewires dependencies to Spezi, updating target dependencies and removing main-actor isolation settings. Study.swift imports SpeziLocalization, bumps studyRevision to 41, and changes study metadata fields to localized forms while removing enrollmentConditions: .none.

Changes

Spezi dependency consolidation and localized study metadata

Layer / File(s) Summary
Package manifest: platform and dependency rewire
Package.swift
Removes visionOS(.v2) from platforms; adds Spezi, rewires target dependencies to Spezi products, and removes swiftSettings defaultIsolation entries.
Study.swift: SpeziLocalization import and localized metadata
Sources/MHCStudyDefinitionExporter/Study.swift
Imports SpeziLocalization; increments studyRevision to 41; converts title, shortTitle, explanationText, and shortExplanationText to localized dictionary values; removes enrollmentConditions: .none; adds a Spanish localization key.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • PSchmiedmayer
  • PaulGoldschmidt
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the dependency update, but it is too vague to convey the main change. Rename it to mention the Spezi dependency migration, e.g. 'Migrate dependencies to the new Spezi repository'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lukas/update-deps

Comment @coderabbitai help to get the list of available commands.

Comment thread Package.swift Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Package.swift`:
- Around line 42-47: The MHCStudyDefinitionExporter target's dependencies array
is missing three required Spezi products that are imported by the target. Add
the following three product dependencies to the dependencies array in
Package.swift: .product(name: "SpeziFoundation", package: "Spezi"),
.product(name: "SpeziHealthKit", package: "Spezi"), and .product(name:
"SpeziScheduler", package: "Spezi"). These products must be declared in the same
format as the existing Spezi products in the dependencies list to ensure the
target can access the imported modules and compile successfully.

In `@Sources/MHCStudyDefinitionExporter/Study.swift`:
- Around line 43-49: The explanationText property in the metadata initialization
for the Study definition is set to an empty dictionary, which violates Spezi 0.2
requirements that mandate at least one localization entry in localized
dictionaries. Replace the empty dictionary in explanationText with at least one
language entry following the same pattern as shortExplanationText, using the
format [.enUS: "descriptive text"] to provide localized content for the UI.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ae0d055-4064-4b3c-9cab-65c8de1d159f

📥 Commits

Reviewing files that changed from the base of the PR and between 5ccee31 and 08d8df5.

📒 Files selected for processing (2)
  • Package.swift
  • Sources/MHCStudyDefinitionExporter/Study.swift

Comment thread Package.swift
Comment thread Sources/MHCStudyDefinitionExporter/Study.swift Outdated

@PSchmiedmayer PSchmiedmayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally happy to merge, we should just ensure that we don't push this into production before we don't have the "backup loading" iOS version released to the App Store.

I think we should we disable the GitHub Action that does releases to Prod temporarily here as part of the PR to avoid any pushes there.

From my understanding, it should work if that release is not published:

  1. Before we release here:
    a) App version currently in the App Store will still pickup the definitions from the bucket
    b)App version to be published will fall back to the built-in version as it fails to old the old study bundle version.

  2. Once we release here:
    a) App version currently in the App Store will fail on new install and will prompt the user to update the app; existing install will continue to work, but not pick up any updates. First part should never happen as the new app version would be released so basically all fine ...
    b) App version to be published will work great as it will pick up the new version from the bucket (and even if that would fail, it would have the locally bundled backup).

@lukaskollmer lukaskollmer merged commit d0b87d4 into main Jun 25, 2026
5 checks passed
@lukaskollmer lukaskollmer deleted the lukas/update-deps branch June 25, 2026 12:20
@github-project-automation github-project-automation Bot moved this from In Progress to Done in MyHeart Counts Project Planning Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

2 participants