Skip to content

fix deployment#36

Merged
lukaskollmer merged 5 commits into
mainfrom
lukas/hmmm
Jul 1, 2026
Merged

fix deployment#36
lukaskollmer merged 5 commits into
mainfrom
lukas/hmmm

Conversation

@lukaskollmer

@lukaskollmer lukaskollmer commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

fix deployment

♻️ Current situation & Problem

issues:

  • some workflows still were pointing to the old org
  • for some reason we need to switch to self-hosted runners bc the swift versions we can get on the GH runners somehow fail at psrsing the Spezi package manifest?

⚙️ Release Notes

  • fixed deployment

📚 Documentation

n/a

✅ Testing

n/a

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Documentation

    • Updated the project README links, badges, and organization references.
    • Refreshed the footer and licensing information shown on the page.
  • Chores

    • Switched several automated checks and verification jobs to updated shared workflow templates.
    • Moved one publishing job to run on a self-hosted macOS environment.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4face852-ff9f-4fd7-ac5c-a54bbb34d100

📥 Commits

Reviewing files that changed from the base of the PR and between d0b87d4 and dfc8f8f.

📒 Files selected for processing (5)
  • .github/workflows/monthly-markdown-link-check.yml
  • .github/workflows/publish-study-definition.yml
  • .github/workflows/static-analysis.yml
  • .github/workflows/verify-study-bundle.yml
  • README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lukas/hmmm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lukaskollmer lukaskollmer merged commit bd76f59 into main Jul 1, 2026
4 of 5 checks passed
@lukaskollmer lukaskollmer deleted the lukas/hmmm branch July 1, 2026 17:55
@github-project-automation github-project-automation Bot moved this from In Progress to Done in MyHeart Counts Project Planning Jul 1, 2026
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/publish-study-definition.yml (1)

78-81: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

The build job still uses setup-xcode

The build job is on a self-hosted macOS runner, but it still uses maxim-lobanov/setup-xcode@v1. If this PR is meant to switch that job to swift-actions/setup-swift, the change is missing here; otherwise the commit message should be updated.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/publish-study-definition.yml around lines 78 - 81, The
build job still uses maxim-lobanov/setup-xcode@v1 instead of the intended
swift-actions/setup-swift, so update the workflow step in the build job to use
the Swift setup action if this PR is meant to make that switch, or else align
the commit/message with the unchanged Xcode setup. Use the job and step
identifiers around Setup Xcode in the workflow to locate the replacement point.
🧹 Nitpick comments (1)
.github/workflows/static-analysis.yml (1)

23-32: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Consider adding an explicit permissions: block.

Static analysis flags this workflow as relying on default (broad) permissions. Not introduced by this change, but since the file is being touched, worth tightening.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/static-analysis.yml around lines 23 - 32, Add an explicit
permissions block to the static-analysis workflow to avoid relying on default
broad GitHub Actions permissions. Update the workflow definition alongside the
existing reuse_action, swiftlint, and markdown_link_check jobs to declare only
the minimal required permissions for these checks, keeping the scope tight and
intentional.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.github/workflows/publish-study-definition.yml:
- Around line 78-81: The build job still uses maxim-lobanov/setup-xcode@v1
instead of the intended swift-actions/setup-swift, so update the workflow step
in the build job to use the Swift setup action if this PR is meant to make that
switch, or else align the commit/message with the unchanged Xcode setup. Use the
job and step identifiers around Setup Xcode in the workflow to locate the
replacement point.

---

Nitpick comments:
In @.github/workflows/static-analysis.yml:
- Around line 23-32: Add an explicit permissions block to the static-analysis
workflow to avoid relying on default broad GitHub Actions permissions. Update
the workflow definition alongside the existing reuse_action, swiftlint, and
markdown_link_check jobs to declare only the minimal required permissions for
these checks, keeping the scope tight and intentional.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4face852-ff9f-4fd7-ac5c-a54bbb34d100

📥 Commits

Reviewing files that changed from the base of the PR and between d0b87d4 and dfc8f8f.

📒 Files selected for processing (5)
  • .github/workflows/monthly-markdown-link-check.yml
  • .github/workflows/publish-study-definition.yml
  • .github/workflows/static-analysis.yml
  • .github/workflows/verify-study-bundle.yml
  • README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Development

Successfully merging this pull request may close these issues.

1 participant