[SCI-22111][NGX][NGL][NIR][Security] Switch to https for Profile Builder#19
Open
AnkitManeSciAps wants to merge 17 commits intomasterfrom
Open
[SCI-22111][NGX][NGL][NIR][Security] Switch to https for Profile Builder#19AnkitManeSciAps wants to merge 17 commits intomasterfrom
AnkitManeSciAps wants to merge 17 commits intomasterfrom
Conversation
AnkitManeSciAps
requested review from
AlishaJeanFarmer,
dieter-sciaps,
ftr-sciaps,
jenksm,
kdoudkinsciaps and
yuriysciaps
as code owners
ftr-sciaps
reviewed
Nov 17, 2025
miniweb-core/src/main/java/com/devsmart/miniweb/ServerBuilder.java
Outdated
Show resolved
Hide resolved
ftr-sciaps
reviewed
Nov 17, 2025
ftr-sciaps
reviewed
Nov 17, 2025
yuriysciaps
reviewed
Nov 19, 2025
yuriysciaps
approved these changes
Nov 19, 2025
AnkitManeSciAps
commented
Nov 26, 2025
Comment on lines
+240
to
+250
| public static class SSLSafeHttpServerConnection extends DefaultHttpServerConnection { | ||
| @Override | ||
| public void close() throws IOException { | ||
| try { | ||
| // This attempts to call shutdownOutput(), which fails on Android SSL | ||
| super.close(); | ||
| } catch (UnsupportedOperationException e) { | ||
| // Catch the specific Android error | ||
| // verify the socket exists and force-close it to prevent leaks | ||
| if (getSocket() != null) { | ||
| getSocket().close(); |
Author
There was a problem hiding this comment.
https://square.github.io/okhttp/changelogs/changelog/#version-521
close() method attempts to call shutdownOutput() which fails and throw the exception and thus to avoid it I had to override the implementation and catch it in and close force-close the socket to prevent leaks
ftr-sciaps
reviewed
Dec 1, 2025
| private boolean mIsDebugBuild; | ||
| private KeyManager[] mKeyManagers; | ||
| private TrustManager[] mTrustManagers; | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(ServerBuilder.class.getSimpleName()); |
ftr-sciaps
approved these changes
Dec 1, 2025
yuriysciaps
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.