-
Notifications
You must be signed in to change notification settings - Fork 36
Send email on doi registration desy changes #2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rkweehinzmann
wants to merge
12
commits into
master
Choose a base branch
from
send-email-on-doi-registration-DESY-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+134
−7
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2844f22
enable gitlab ci, push to harbor
a31a985
send email after DOI registration
ffe5d46
use prod api
rkweehinzmann bb4ffc5
use registerDoiUri
rkweehinzmann ed8784b
introduce registerDoiUri
rkweehinzmann 60764c2
get registerDoiUri from config
273a3c0
add debug logger
rkweehinzmann 27cd879
rm slash as registerDoiUri should end with slash
rkweehinzmann 482f736
test replacements of api with doi in email
rkweehinzmann ce4dc03
add exchangeString to handlebarsHelpers
rkweehinzmann 172cf48
add output statement of registerDataciteDoiOptions
rkweehinzmann 81df3f5
Link to PubDB
rkweehinzmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // For format details, see https://aka.ms/devcontainer.json. For config options, see the | ||
| // README at: https://github.com/devcontainers/templates/tree/main/src/debian | ||
| { | ||
| "name": "Debian", | ||
| // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile | ||
| "image": "mcr.microsoft.com/devcontainers/base:trixie", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/node:1": {} | ||
| } | ||
|
|
||
| // Features to add to the dev container. More info: https://containers.dev/features. | ||
| // "features": {}, | ||
|
|
||
| // Use 'forwardPorts' to make a list of ports inside the container available locally. | ||
| // "forwardPorts": [], | ||
|
|
||
| // Configure tool-specific properties. | ||
| // "customizations": {}, | ||
|
|
||
| // Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root. | ||
| // "remoteUser": "root" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| stages: | ||
| - build | ||
| - publish | ||
|
|
||
| build_image: | ||
| stage: build | ||
| image: | ||
| name: gcr.io/kaniko-project/executor:debug | ||
| entrypoint: [""] | ||
| script: | ||
| - |- | ||
| tag=$CI_COMMIT_SHORT_SHA | ||
| if [[ -n "$CI_COMMIT_TAG" ]]; then | ||
| tag=$CI_COMMIT_TAG | ||
| fi | ||
| - mkdir -p /kaniko/.docker | ||
| - echo "{\"auths\":{\"$CI_REGISTRY\":{\"username\":\"$CI_REGISTRY_USER\",\"password\":\"$CI_REGISTRY_PASSWORD\"}}}" > /kaniko/.docker/config.json | ||
| - > | ||
| /kaniko/executor | ||
| --context $CI_PROJECT_DIR | ||
| --dockerfile $CI_PROJECT_DIR/Dockerfile | ||
| --destination $CI_REGISTRY_IMAGE:${tag} | ||
| --cache=true | ||
|
|
||
| push_image_harbor: | ||
| stage: publish | ||
| image: | ||
| name: gcr.io/kaniko-project/executor:debug | ||
| entrypoint: [''] | ||
| script: | ||
| - mkdir -p /kaniko/.docker | ||
| - echo "{\"auths\":{\"${HARBOR_HOST}\":{\"auth\":\"$(echo -n ${HARBOR_USERNAME}:${HARBOR_PASSWORD} | base64 -w 0)\"}}}" > /kaniko/.docker/config.json | ||
| - >- | ||
| /kaniko/executor | ||
| --context "${CI_PROJECT_DIR}" | ||
| --dockerfile ${CI_PROJECT_DIR}/Dockerfile | ||
| --destination "${HARBOR_HOST}/${HARBOR_PROJECT}/${CI_PROJECT_NAME}:${CI_COMMIT_TAG}" | ||
| --cache=true | ||
| rules: | ||
| - if: $CI_COMMIT_TAG | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import { Module } from "@nestjs/common"; | ||
| import { MailService } from "./mail.service"; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't have 'services' directories elsewhere in the project. Is this file rename necessary? |
||
| import { MailService } from "./services/mail.service"; | ||
|
|
||
| @Module({ | ||
| providers: [MailService], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <p>Hello,</p> | ||
|
|
||
| <p>Your DOI has been successfully registered: <strong><a href="{{exchangeString registerDoiUri "api" "doi"}}{{{urlencode doi}}}">{{doi}}</a></strong></p> | ||
|
|
||
| <p>Please proceed to DESY's publication database <a href="https://bib-pubdb1.desy.de/submit/direct?ln=en&sub=SBIdataset&hgf_import={{{urlencode doi}}}">PubDB.</a></p> | ||
|
|
||
| <p>Best regards,<br> | ||
| Your Service Team</p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess .gitlab-ci is desy-specific and should not be included in the final PR