feat(publish): add support for ajv dynamic defaults#2569
Open
feat(publish): add support for ajv dynamic defaults#2569
Conversation
fpotier
force-pushed
the
feat/dynamic-defaults
branch
from
f9c0c5c to
faab069
Compare
fpotier
force-pushed
the
feat/dynamic-defaults
branch
from
faab069 to
db52a8a
Compare
Member
|
Looks good to me. |
minottic
reviewed
Mar 17, 2026
Member
minottic
left a comment
minottic
left a comment
There was a problem hiding this comment.
can we add a file with an example of the js dynamic default files?
| } | ||
| } | ||
|
|
||
| await this.validatorService.validate(updatePublishedDataDto); |
Member
There was a problem hiding this comment.
don't we need to raise errors here if there are during the validation?
| addKeywords(this.ajv); | ||
|
|
||
| const modulePath = this.configService.get<string>("ajvCustomDefinitions"); | ||
| if (!isEmpty(modulePath)) { |
Member
There was a problem hiding this comment.
minor:
if (isEmpty(modulePath)): return| | PartialUpdatePublishedDataV4Dto, | ||
| ) { | ||
| await this.loadDynamicDefaultFunctions(publishedData); | ||
| const config = this.configService.get<Record<string, unknown>>( |
Member
There was a problem hiding this comment.
this will be loaded on every validate, maybe better in the constructor?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements this idea
Note:
PublishedData.metadata.publicationYearis now set using the new dynamic default feature. This required a change in the schema that currently breaks the frontend. I can remove it if it's not desired but I thought it was an improvement as the previous behavior only set a default value on creation that could be overwritten with updates.Motivation
See dedicated discussion
Fixes
Changes:
Tests included
Documentation
official documentation info