feat(ldap-auth): make querying user groups possible#2585
Open
cchndl wants to merge 1 commit intoSciCatProject:masterfrom
Open
feat(ldap-auth): make querying user groups possible#2585cchndl wants to merge 1 commit intoSciCatProject:masterfrom
cchndl wants to merge 1 commit intoSciCatProject:masterfrom
Conversation
add config options and use correct accessGroupProperty and add group extracting service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ldap authenticator did not query the groups from ldap until now.
Add the required config options for getting the groups from ldap. For this we just expose the existing options from node-ldapauth-fork/passport-ldapauth from the SciCat config.
Add a group extraction service for the LDAP response and register it to the servicefactory if enabled.
Additional fixes:
The
AccessGroupFromPayloadServicedid not correctly check whether the elements inpayload[accessGroupsProperty]are strings.