Skip to content

1498 Detection of non unique flows in the FlowModel#1499

Merged
reneSchm merged 2 commits intomainfrom
1498-detection-of-duplicates-in-flows
Feb 26, 2026
Merged

1498 Detection of non unique flows in the FlowModel#1499
reneSchm merged 2 commits intomainfrom
1498-detection-of-duplicates-in-flows

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Feb 26, 2026

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Remove the flow duplicate in the secirts model
  • Static assert to ensure that this detected earlier

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu linked an issue Feb 26, 2026 that may be closed by this pull request
2 tasks
@HenrZu HenrZu requested a review from reneSchm February 26, 2026 10:01
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.42%. Comparing base (02bfed0) to head (fb923e3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
+ Coverage   97.40%   97.42%   +0.01%     
==========================================
  Files         189      189              
  Lines       16600    16600              
==========================================
+ Hits        16170    16172       +2     
+ Misses        430      428       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, thanks.

@reneSchm reneSchm merged commit 12db98b into main Feb 26, 2026
57 checks passed
@reneSchm reneSchm deleted the 1498-detection-of-duplicates-in-flows branch February 26, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate detection of flows

2 participants