Open
Conversation
thompson318
reviewed
Jul 9, 2024
Collaborator
thompson318
left a comment
There was a problem hiding this comment.
Thanks @mxochicale for looking into this. I think that should solve the problems that @younes1010 identified. At the moment the github actions are failing. I'd like to try and sort that before approving/merging.
thompson318
approved these changes
Jul 25, 2024
Collaborator
thompson318
left a comment
There was a problem hiding this comment.
Looks good, thanks @mxochicale. I've made some changes to get tests passing. Minor change to conda notes: we shouldn't need to install the development requirements to run the tutorial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @thompson318 @MattClarkson
There might other bits to update but I think I fixed #37 by updating pyside2 to pyside6 and adding missing vtk steps
self.vtk_overlay_window.Initialize()andself.vtk_overlay_window.Start(). Would you please review it!Some other pending bits might be:
Thanks,
Miguel