QA: run_qa v1.6 form + ExplicitImports#77
Merged
ChrisRackauckas merged 3 commits intoJul 3, 2026
Merged
Conversation
Convert the hand-rolled test/qa/qa.jl (Aqua.test_all + JET.report_package with manual @test_broken placeholders) onto SciMLTesting 1.6.0's run_qa, and enable the ExplicitImports checks (explicit_imports = true). Preserved tracked-broken findings (issue SciML#70): - Aqua undefined_exports (symbolic_steady_states) -> aqua_broken = (:undefined_exports,) - Aqua stale_deps (ReactionNetworkImporters, PolynomialRoots, ModelingToolkit, SBMLToolkit) -> aqua_broken = (:stale_deps,) - Aqua deps_compat extras (Pkg missing [compat]) -> preserved as the non-broken aqua_kwargs tweak deps_compat = (check_extras = false,) - JET report-mode + @test_broken -> jet_broken = true. Verified locally the finding still reproduces (14 reports) only with the original invocation (target_defined_modules = true, NO target_modules narrowing), so jet_kwargs overrides the run_qa default to drop target_modules. ExplicitImports findings (6 checks vs released SciMLTesting 1.6.0): - no_stale_explicit_imports: FIXED. `using PrecompileTools: @setup_workload, @compile_workload` was imported but never used (no workload block exists); removed the import and dropped PrecompileTools from [deps]/[compat]. - no_implicit_imports: ei_broken. The package `using`s several large deps (Catalyst, Oscar, JuMP, Graphs, DynamicPolynomials, Satisfiability, ...) and relies on ~75 of their exported names implicitly; making each explicit is a large refactor (tracked in issue SciML#70). - all_qualified_accesses_via_owners / all_qualified_accesses_are_public: ignore non-public names accessed from other packages via Mod.name (BasicSymbolic [SymbolicUtils via Symbolics], Library [CDDLib], Optimizer [HiGHS], assemble_oderhs/cycles/get_networkproperties/symmap_to_varmap [Catalyst], n_positive_roots [Hecke]). - all_explicit_imports_via_owners / all_explicit_imports_are_public: pass. Deps: test/qa/Project.toml SciMLTesting compat -> "1.6"; dropped unused SafeTestsets; kept Aqua (ambiguities child-proc needs it direct) and JET. Local verification (Julia 1.10, released SciMLTesting 1.6.0): Quality Assurance | Pass: 13 Broken: 4 Total: 17 (0 Fail, 0 Error) Ignore until reviewed by @ChrisRackauckas. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… ignores Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
…non-public re-exports) Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Converts the hand-rolled
test/qa/qa.jl(manualAqua.test_all+JET.report_packagewith@test_brokenplaceholders) onto SciMLTesting 1.6.0'srun_qa, and enables the ExplicitImports checks (explicit_imports = true).Preserved tracked-broken findings (issue #70)
undefined_exports(symbolic_steady_states) ->aqua_broken = (:undefined_exports,)stale_deps(ReactionNetworkImporters, PolynomialRoots, ModelingToolkit, SBMLToolkit) ->aqua_broken = (:stale_deps,)deps_compatextras (Pkg missing[compat]) -> preserved as the non-brokenaqua_kwargstweakdeps_compat = (check_extras = false,); the deps/weakdeps/julia compat checks still run and pass@test_broken->jet_broken = true. Verified locally the finding still reproduces (14 reports) only with the original invocation (target_defined_modules = true, notarget_modulesnarrowing);jet_kwargstherefore overrides the run_qa default to droptarget_modulesso the genuine reports are surfaced asBrokenrather than filtered out.ExplicitImports findings (6 checks, vs released SciMLTesting 1.6.0)
using PrecompileTools: @setup_workload, @compile_workloadwas imported but never used (no@compile_workloadblock exists anywhere in the package). Removed the import and droppedPrecompileToolsfrom root[deps]/[compat].ei_broken. The packageusings several large dependencies (Catalyst, Oscar, JuMP, Graphs, DynamicPolynomials, Satisfiability, ...) and relies on ~75 of their exported names implicitly. Making each explicit is a large, risky refactor; tracked in issue QA: Aqua/JET findings marked @test_broken pending fix #70 asei_broken = (:no_implicit_imports,)(auto-flags once addressed).Mod.name:BasicSymbolic(SymbolicUtils, via Symbolics),Library(CDDLib),Optimizer(HiGHS),assemble_oderhs/cycles/get_networkproperties/symmap_to_varmap(Catalyst),n_positive_roots(Hecke). Each ignore documents its source package.Deps
test/qa/Project.toml: SciMLTesting compat ->"1.6"; dropped unusedSafeTestsets; keptAqua(the ambiguities sub-check spawns a child process that needs Aqua as a direct dep) andJET(jet_broken runs). ExplicitImports stays transitive via SciMLTesting (not added as a direct dep).Local verification (Julia 1.10, released SciMLTesting 1.6.0,
[sources] = ../..)0 Fail, 0 Error. The 4 Broken are the preserved tracked findings:
undefined_exports,stale_deps,jet_broken(14 reports),no_implicit_imports.🤖 Generated with Claude Code