Raise Mooncake compat floor to 0.5.36 (fix Downgrade resolution)#551
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Raise Mooncake compat floor to 0.5.36 (fix Downgrade resolution)#551ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
The old Mooncake compat union "0.4.175, 0.5" let the Downgrade job pin an ancient Mooncake (0.4.175) at minimum resolution. Mooncake is a weakdep that is also a test-target dep, so julia-downgrade-compat's merged resolution promotes it weakdep->dependency and resolves it at its floor. Narrowing the floor to the latest (0.5.36) stops the downgrade from selecting the ancient 0.4.x line. Verified on Julia 1.12 by running julia-actions/julia-downgrade-compat@v2 (mode=deps, merged extras resolution) on the repo: with the raised floor the resolver picks Mooncake v0.5.36 and reports "Successfully resolved minimal versions"; the downgraded environment instantiates and precompiles cleanly. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Contributor
Author
|
Closing. Verified locally (ran the action's own downgrade.jl on the identical commit CI failed on) that raising the Mooncake compat floor does NOT fix the Downgrade lane. The failure is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise Mooncake compat floor to 0.5.36 (fix Downgrade resolution)
The root
Project.tomldeclaredMooncake = "0.4.175, 0.5". Mooncake is aweakdep (backs
DataInterpolationsMooncakeExt) that is also a test-targetdependency.
julia-actions/julia-downgrade-compat@v2uses a mergedresolution for old-style
[extras]/[targets].testprojects and promotesMooncake from weakdep to a full dependency, then resolves it at its minimum.
With the old union floor, the downgrade job pins the ancient Mooncake
0.4.175, which is the "promotion-caused Downgrade
Unsatisfiablewall".This narrows the floor to the latest published Mooncake so the downgrade can no
longer select the ancient 0.4.x line.
Change
Project.toml:Mooncake = "0.4.175, 0.5"->Mooncake = "0.5.36"9.0.0->9.0.1(compat narrowing is a patch-level change; aMooncake weakdep floor is not public API)
Old floor raised:
Mooncake = "0.4.175, 0.5"->"0.5.36"(rootProject.toml).Verification (
resolves_at_min= true)Ran
julia-actions/julia-downgrade-compat@v2(the@v2tip = commit828d417, i.e. the merged-test-deps path) on this repo on Julia 1.12,mode=deps, projects=.— identical to the centralizedSciML/.github/.github/workflows/downgrade.yml@v1invocation this repo uses:[ Info: Successfully resolved minimal versions for . (with extras). Thedowngraded environment then instantiates and precompiles cleanly
(
DataInterpolationsprecompiled,INSTANTIATE_OK, exit 0). Mooncake isconfirmed promoted weakdep -> dependency in the merged project.
0.4.175 — exactly what the raise removes.
So on the current registry snapshot the floor-raise alone yields a clean
downgrade min-resolution; the Resolver-capacity wall (
#52) is not hit forthis repo here (
resolves_at_min = true).Please ignore until reviewed by @ChrisRackauckas.