Fix OrdinaryDiffEq 7.0.0 re-export breakage in tests#212
Merged
ChrisRackauckas merged 1 commit intoJun 7, 2026
Merged
Conversation
OrdinaryDiffEq 7.0.0 dropped its blanket solver re-exports (deps 30->6 for faster TTFS). VCAB3 now lives in OrdinaryDiffEqAdamsBashforthMoulton and is no longer exported by OrdinaryDiffEq, and the bare SciMLBase module name is no longer re-exported either. test/layers_tests.jl used both (VCAB3 in the SOLVERS tuple, SciMLBase.AbstractODEAlgorithm in the multiscale node branch), so loading the file threw UndefVarError under ODE7. Import VCAB3 from OrdinaryDiffEqAdamsBashforthMoulton and bring the SciMLBase module name into scope explicitly. Add OrdinaryDiffEqAdamsBashforthMoulton to the test deps ([extras] + test target + [compat] "1, 2" to keep ODE6 downgrade resolvable). Verified locally on Julia 1.10 at latest deps (OrdinaryDiffEq v7.0.0): Utils Tests 13/13, Layers Tests 1538/1538 passed. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Problem
OrdinaryDiffEq 7.0.0 intentionally dropped its blanket solver re-exports (cutting deps 30 -> 6 for faster TTFS; see ODE NEWS.md). The documented downstream migration is to import non-default solvers from their sub-packages.
test/layers_tests.jlrelied on two names that ODE7 no longer exports, so the file threwUndefVarErrorat load time under ODE7:VCAB3()(line 14, in theSOLVERStuple) — moved toOrdinaryDiffEqAdamsBashforthMoulton.SciMLBase.AbstractODEAlgorithm(multiscale:nodebranch) — the bareSciMLBasemodule name is no longer re-exported by OrdinaryDiffEq.Fix
test/layers_tests.jl:using OrdinaryDiffEqAdamsBashforthMoulton: VCAB3andusing SciMLBase: SciMLBase.Project.toml: addOrdinaryDiffEqAdamsBashforthMoultonto[extras], thetesttarget, and[compat]("1, 2"so the package still resolves under both ODE6 and ODE7, keeping the downgrade workflow green).Minimal change; no source files touched.
Tsit5(still exported by ODE7) and the other solvers in the tuple were unaffected.Verification
Ran the full CPU suite locally on Julia 1.10 at latest deps (resolved
OrdinaryDiffEq v7.0.0):Confirmed the
UndefVarErrorreproduces on unmodifiedmainat the same deps and is gone with this fix.🤖 Generated with Claude Code