This repository was archived by the owner on Mar 24, 2026. It is now read-only.
fix: add DynamicQuantities extension for unitful factorization paths#1293
Merged
ChrisRackauckas merged 2 commits intoSciML:masterfrom Mar 17, 2026
Merged
fix: add DynamicQuantities extension for unitful factorization paths#1293ChrisRackauckas merged 2 commits intoSciML:masterfrom
ChrisRackauckas merged 2 commits intoSciML:masterfrom
Conversation
MilesCranmer
reviewed
Mar 8, 2026
There was a problem hiding this comment.
@MilesCranmerBot I think you forgot to include unittests in this PR? Please add them and ensure 100% code coverage here.
Contributor
Author
|
Added unit tests for the DynamicQuantities extension (incl. DQUnitlessLU factorization bridge + norm/time hooks) and wired the extension in Project.toml ([weakdeps]/[extensions]/[compat] + added DynamicQuantities to test target). Local run: Commit: 0bd73ec (pushed to wave2-dq-compat). |
Comment on lines
+43
to
+67
| function LinearAlgebra.ldiv!( | ||
| x::AbstractVector{<:UnionAbstractQuantity}, | ||
| W::DQUnitlessLU, | ||
| b::AbstractVector{<:UnionAbstractQuantity}, | ||
| ) | ||
| vb = ustrip.(b) | ||
| vx = similar(vb) | ||
| LinearAlgebra.ldiv!(vx, W.F, vb) | ||
| @inbounds for i in eachindex(x) | ||
| x[i] = vx[i] * (oneunit(b[i]) * W.ut) | ||
| end | ||
| return x | ||
| end | ||
|
|
||
| function Base.:(\)(W::DQUnitlessLU, b::AbstractVector{<:UnionAbstractQuantity}) | ||
| vb = ustrip.(b) | ||
| vx = W.F \ vb | ||
| out = similar(b) | ||
| @inbounds for i in eachindex(out) | ||
| out[i] = vx[i] * (oneunit(b[i]) * W.ut) | ||
| end | ||
| return out | ||
| end | ||
|
|
||
| end |
There was a problem hiding this comment.
DQUnitlessLU is defined above, so I think it's fine, no?
ChrisRackauckas
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 2 (post-DynamicQuantities release) for the DynamicQuantities × SciML rollout.
Tracking issue: JuliaPhysics/DynamicQuantities.jl#200
What this changes
Adds
ext/DiffEqBaseDynamicQuantitiesExt.jlto define DynamicQuantities-specific DiffEqBase behaviors:ODE_DEFAULT_NORM/UNITLESS_ABS2timedepentdtminand_rate_prototypehandling for quantity timesDQUnitlessLU) for Rosenbrock/SDIRK Jacobian solves with quantity eltypesThis keeps factorization in numeric value-space while restoring output units consistently.
Test
julia --project=. -e 'using Pkg; Pkg.test()'