Raise OrdinaryDiffEqNonlinearSolve downgrade floor to 1.15.0 (fixes Downgrade Core)#320
Merged
ChrisRackauckas merged 1 commit intoJun 28, 2026
Conversation
The Downgrade Core lane errored in test/saving_tests.jl ("fail
gracefully" testset) with:
MethodError: no method matching _initialize_dae!(
...DFBDF..., ..., ::DiffEqBase.BrownFullBasicInit, ::Val{false})
At the resolved floor, OrdinaryDiffEqNonlinearSolve dispatched
_initialize_dae! on its own OrdinaryDiffEqCore.BrownFullBasicInit
init type, while the test (and DiffEqBase) pass a
DiffEqBase.BrownFullBasicInit. OrdinaryDiffEqNonlinearSolve 1.15.0 is
the first registered version that unifies the DAE-init algorithms onto
the DiffEqBase-owned types (it imports BrownFullBasicInit from
OrdinaryDiffEqCore, which itself re-exports DiffEqBase's), so its
_initialize_dae! methods dispatch on DiffEqBase.BrownFullBasicInit.
The previous floor 1.5.0 still defined and dispatched on the
OrdinaryDiffEqCore-owned type, so passing DiffEqBase's hit no method.
Verified on Julia 1.10 (LTS) by reproducing the downgrade resolution
(julia-downgrade-compat deps mode + Pkg.test GROUP=Core, allow_reresolve
=false): with the floor at 1.15.0 the resolver picks
OrdinaryDiffEqNonlinearSolve 1.15.0 and Core/saving_tests.jl passes
112/112 (the previously-erroring testset now passes); the full Core
group reports "Testing DiffEqCallbacks tests passed".
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Downgrade / Downgrade Tests - Corelane is red on master. At the minimum-version (downgrade) resolution it errors intest/saving_tests.jl("fail gracefully" testset):The test does
using DiffEqBase: BrownFullBasicInitand passesBrownFullBasicInit(nlsolve = NewtonRaphson())asinitializealg. At the resolved floor, the_initialize_dae!methods provided byOrdinaryDiffEqNonlinearSolvedispatched on its ownOrdinaryDiffEqCore.BrownFullBasicInitinit type, which is a different type fromDiffEqBase.BrownFullBasicInit— so no method matched.Fix
OrdinaryDiffEqNonlinearSolve1.15.0 is the first registered version that unifies the DAE-initialization algorithms onto the DiffEqBase-owned types: it importsBrownFullBasicInitfromOrdinaryDiffEqCore(which in turn re-exportsDiffEqBase.BrownFullBasicInit), and its_initialize_dae!methods dispatch onDiffEqBase.BrownFullBasicInit. The previous floor1.5.0predates that migration, so theDiffEqBase-owned init type passed by the test hit no method.This raises only the
[compat]lower bound forOrdinaryDiffEqNonlinearSolvefrom1.5.0to1.15.0. No source changes.Verification (Julia 1.10 / LTS)
Reproduced the downgrade resolution faithfully (
julia-actions/julia-downgrade-compatdepsmode via the action'sdowngrade.jl, thenPkg.test("DiffEqCallbacks"; allow_reresolve=false)withGROUP=Core):OrdinaryDiffEqNonlinearSolve1.15.0 at the floor.Core/saving_tests.jlpasses 112/112 (the previously-erroring "fail gracefully" testset now passes).Testing DiffEqCallbacks tests passed(0 fail / 0 error).Please ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code