Canonical CI: grouped-tests.yml + root test/test_groups.toml#49
Merged
ChrisRackauckas merged 3 commits intoJun 10, 2026
Merged
Conversation
Convert the root Tests workflow to the canonical thin caller (SciML/.github/.github/workflows/grouped-tests.yml@v1) with the group x version matrix declared once in test/test_groups.toml. - Tests.yml: replace the hand-maintained version matrix test job with the grouped-tests.yml@v1 caller; on:/concurrency:/name: preserved. - test/test_groups.toml: Core on [lts, 1, pre] (reproduces the old matrix), QA on [lts, 1]. Linux-only, no os axis. - runtests.jl: add GROUP dispatch (existing suite under Core/All). - test/qa/ (new): Aqua.test_all + JET.test_package, gated GROUP=="QA", with its own Project.toml ([sources] path to the root package). - Project.toml: bump julia compat 1.6 -> 1.10 (LTS floor) and add missing [compat] entries for extras/stdlib deps (benign metadata). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The QA group includes test/qa/qa.jl directly under the root test environment (no separate qa env activation), so Aqua and JET must be available there. They were absent from [extras]/[targets].test, causing the QA group to fail with Aqua/JET not found. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Keeps the passing Aqua sub-checks enabled and disables the two failing ones (deps_compat for Aqua/JET extras, piracies on the @recipe-generated apply_recipe), marking each @test_broken. Replaces the failing JET.test_package call with @test_broken for the is_key_supported finding. All three are tracked in SciML#50. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the root Tests workflow to the canonical thin caller,
SciML/.github/.github/workflows/grouped-tests.yml@v1, with the group x version matrix declared once intest/test_groups.toml.Changes
.github/workflows/Tests.yml— replaced the hand-maintainedversionmatrix test job (which calledtests.yml@v1over["1","lts","pre"]) with thegrouped-tests.yml@v1thin caller.name:,on:, andconcurrency:preserved verbatim. Nowith:needed:runtests.jlreads the defaultGROUPenv var,check-boundsdefault (yes),coveragedefault (true, repo has.codecov.yml), andcoverage-directoriesdefault (src,ext) all apply. Linux-only, so noosaxis.test/test_groups.toml(new, root) —Coreon["lts","1","pre"],QAon["lts","1"].test/runtests.jl— addedGROUPdispatch; the existing suite runs underCore/All.test/qa/(new) —qa.jlrunsAqua.test_all(DimensionalPlotRecipes)+JET.test_package(DimensionalPlotRecipes; target_defined_modules=true), gated onGROUP=="QA", with its ownProject.toml([deps] Aqua/JET/Test/package via[sources]path../..).Project.toml— benign metadata fixes: bumpedjuliacompat1.6->1.10(LTS floor), added missing[compat]entries for extras (ExplicitImports,Plots,Test) and theLinearAlgebrastdlib dep.Matrix match (static verification)
compute_affected_sublibraries.jl <root> --root-matrixemits:The Core group reproduces the OLD matrix exactly (whole suite over
["1","lts","pre"]on ubuntu-latest). QA is additive. TOML and all workflow YAML parse cleanly.QA group is newly wired; Aqua/JET run in CI — any failures will be triaged in a follow-up. (No exclusions were pre-added.)
Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code