QA: run_qa v1.6 form + ExplicitImports#59
Merged
ChrisRackauckas merged 1 commit intoJun 25, 2026
Merged
Conversation
Convert the hand-rolled `test/qa/qa.jl` (direct `Aqua.test_all` +
`JET.test_package`) onto the SciMLTesting v1.6 `run_qa` form and enable
the ExplicitImports checks:
using SciMLTesting, FastPower, JET, Test
run_qa(FastPower; explicit_imports = true)
Aqua, JET, and all six ExplicitImports checks pass cleanly (FastPower has
no external `[deps]`, so EI is trivially clean — no ignore-lists, no broken
markers needed).
The previous `@test_broken` placeholder for the Aqua `deps_compat` extras
finding (SciML#53) is dropped: that finding was the `Pkg` extra missing a compat
entry, and `Pkg` was already removed from the root `[extras]`/test target in
SciML#54. Verified against released SciMLTesting 1.6.0 that the full default
`Aqua.test_all(FastPower)` now passes the deps_compat (extras) sub-check, so
the marker was stale — issue SciML#53 can be closed.
test/qa/Project.toml: bump SciMLTesting compat to "1.6"; drop the explicit
`check_extras = false` tweak (no longer needed). ExplicitImports stays a
transitive dep via SciMLTesting (not listed directly); Aqua kept as a direct
dep (its ambiguities sub-check child-procs), JET and SafeTestsets kept.
Verified locally (clean depot, released SciMLTesting 1.6.0, GROUP=QA via
run_tests folder-model): Quality Assurance 18/18 Pass, 0 Fail/Error/Broken.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Brings this repo's QA group onto the SciMLTesting v1.6
run_qaform and enables the ExplicitImports checks.test/qa/qa.jlReplaces the hand-rolled
Aqua.test_all+JET.test_packagebody with:ExplicitImports findings
FastPower's
src/FastPower.jlimports nothing external (root[deps]is empty). All six EI checks pass with no curation:no_implicit_importsno_stale_explicit_importsall_explicit_imports_via_ownersall_qualified_accesses_via_ownersall_qualified_accesses_are_publicall_explicit_imports_are_publicNo
ei_kwargsignore-lists and noei_brokenneeded.Dropped
@test_broken(closes #53)The old
qa.jlcarriedAqua.test_all(FastPower; deps_compat = (; check_extras = false))plus a@test_broken falsefor thedeps_compat(extras) finding tracked in #53. That finding was thePkgextra missing a[compat]entry — andPkgwas already removed from the root[extras]/test target in #54. Verified against released SciMLTesting 1.6.0 that the full defaultAqua.test_all(FastPower)now passes thedeps_compat(extras) sub-check, so the marker was stale. Thecheck_extras = falsetweak and the@test_brokenare both dropped (a fix, not a silenced check). Issue #53 can be closed.test/qa/Project.tomlSciMLTestingcompat"1"→"1.6".ExplicitImportsstays transitive via SciMLTesting (not listed directly).Aquakept as a direct dep (its ambiguities sub-check child-procs and needs Aqua in the env),JETandSafeTestsetskept (SafeTestsetsis required by the folder-model@safetestsetwrapper).Verification (local)
Clean depot, released SciMLTesting 1.6.0 (no dev-from-branch; Pkg resolved
SciMLTesting v1.6.0),GROUP=QAvia therun_tests()folder-model:18/18 Pass, 0 Fail / 0 Error / 0 Broken. Aqua full-default
test_all(8 sub-checks), JET, and all 6 EI checks confirmed individually green.🤖 Generated with Claude Code