Skip to content

QA: run_qa v1.6 form + ExplicitImports#59

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:qa/run_qa-v1.6-explicit-imports
Jun 25, 2026
Merged

QA: run_qa v1.6 form + ExplicitImports#59
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:qa/run_qa-v1.6-explicit-imports

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

Ignore until reviewed by @ChrisRackauckas.

Brings this repo's QA group onto the SciMLTesting v1.6 run_qa form and enables the ExplicitImports checks.

test/qa/qa.jl

Replaces the hand-rolled Aqua.test_all + JET.test_package body with:

using SciMLTesting, FastPower, JET, Test

run_qa(FastPower; explicit_imports = true)

ExplicitImports findings

FastPower's src/FastPower.jl imports nothing external (root [deps] is empty). All six EI checks pass with no curation:

check result
no_implicit_imports PASS
no_stale_explicit_imports PASS
all_explicit_imports_via_owners PASS
all_qualified_accesses_via_owners PASS
all_qualified_accesses_are_public PASS
all_explicit_imports_are_public PASS

No ei_kwargs ignore-lists and no ei_broken needed.

Dropped @test_broken (closes #53)

The old qa.jl carried Aqua.test_all(FastPower; deps_compat = (; check_extras = false)) plus a @test_broken false for the deps_compat (extras) finding tracked in #53. That finding was the Pkg extra missing a [compat] entry — and Pkg was already removed from the root [extras]/test target in #54. Verified against released SciMLTesting 1.6.0 that the full default Aqua.test_all(FastPower) now passes the deps_compat (extras) sub-check, so the marker was stale. The check_extras = false tweak and the @test_broken are both dropped (a fix, not a silenced check). Issue #53 can be closed.

test/qa/Project.toml

  • SciMLTesting compat "1""1.6".
  • ExplicitImports stays transitive via SciMLTesting (not listed directly).
  • Aqua kept as a direct dep (its ambiguities sub-check child-procs and needs Aqua in the env), JET and SafeTestsets kept (SafeTestsets is required by the folder-model @safetestset wrapper).

Verification (local)

Clean depot, released SciMLTesting 1.6.0 (no dev-from-branch; Pkg resolved SciMLTesting v1.6.0), GROUP=QA via the run_tests() folder-model:

Test Summary: | Pass  Total   Time
QA/qa.jl      |   18     18  28.6s

18/18 Pass, 0 Fail / 0 Error / 0 Broken. Aqua full-default test_all (8 sub-checks), JET, and all 6 EI checks confirmed individually green.

🤖 Generated with Claude Code

Convert the hand-rolled `test/qa/qa.jl` (direct `Aqua.test_all` +
`JET.test_package`) onto the SciMLTesting v1.6 `run_qa` form and enable
the ExplicitImports checks:

    using SciMLTesting, FastPower, JET, Test
    run_qa(FastPower; explicit_imports = true)

Aqua, JET, and all six ExplicitImports checks pass cleanly (FastPower has
no external `[deps]`, so EI is trivially clean — no ignore-lists, no broken
markers needed).

The previous `@test_broken` placeholder for the Aqua `deps_compat` extras
finding (SciML#53) is dropped: that finding was the `Pkg` extra missing a compat
entry, and `Pkg` was already removed from the root `[extras]`/test target in
SciML#54. Verified against released SciMLTesting 1.6.0 that the full default
`Aqua.test_all(FastPower)` now passes the deps_compat (extras) sub-check, so
the marker was stale — issue SciML#53 can be closed.

test/qa/Project.toml: bump SciMLTesting compat to "1.6"; drop the explicit
`check_extras = false` tweak (no longer needed). ExplicitImports stays a
transitive dep via SciMLTesting (not listed directly); Aqua kept as a direct
dep (its ambiguities sub-check child-procs), JET and SafeTestsets kept.

Verified locally (clean depot, released SciMLTesting 1.6.0, GROUP=QA via
run_tests folder-model): Quality Assurance 18/18 Pass, 0 Fail/Error/Broken.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 25, 2026 16:36
@ChrisRackauckas ChrisRackauckas merged commit 6028e01 into SciML:main Jun 25, 2026
10 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QA: Aqua/JET findings marked @test_broken pending fix

2 participants