Use SciMLTesting v1.2 (folder-based run_tests)#151
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Replace the hand-written GROUP dispatcher in test/runtests.jl with the declarative `using SciMLTesting; run_tests()` folder-discovery form. Core = the top-level test/*.jl files (the same 9 files the old dispatcher ran for the non-QA branch); QA = test/qa/. The exact set of tests run under each GROUP value (All/Core/QA) is preserved. test/DeepBSDE_Han.jl was never included by the old runtests.jl (a dormant file), so it is moved into test/shared/ — a non-group subfolder that folder-discovery never globs — to keep it from being auto-run as part of Core. No behavior change. Deps: add SciMLTesting to the root [extras]/[targets].test/[compat] and to test/qa/Project.toml; drop Pkg from the test deps + its [compat] entry (the harness owns all Pkg ops now; no test/*.jl references Pkg). test_groups.toml unchanged. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
test/runtests.jlto the SciMLTesting v1.2 folder-discovery model:test/*.jlfiles (the same 9 files the old dispatcher ran for the non-QAbranch:ProblemConstructor,reflect,MLP,DeepSplitting,DeepBSDE,MCSample,NNStopping,NNKolmogorov,NNParamKolmogorov).test/qa/(its existingProject.tomlsub-env, running Aqua).The exact set of tests run under each
GROUPvalue (All/Core/QA) is unchanged —AllandCoreboth run the 9 top-level files;QArunsqa/qa.jl. No assertions were altered.test/DeepBSDE_Han.jlmoved totest/shared/. That file was neverincluded by the oldruntests.jl(a dormant test file). Folder-discovery globs every top-leveltest/*.jlas Core, so leaving it at the top level would have started running it — a behavior change.test/shared/is a non-group subfolder that discovery never globs, so the file stays dormant exactly as before.Dependency edits:
Project.toml: addSciMLTestingto[extras],[targets].test, and[compat](= "1"); widenSafeTestsetscompat to"0.1, 1"; dropPkgfrom the test deps and its[compat]entry (the harness owns allPkgops now — notest/*.jlreferencesPkg).test/qa/Project.toml: addSciMLTesting+SafeTestsets(and compat).test/test_groups.tomlleft unchanged.Ignore until reviewed by @ChrisRackauckas.