Cache inner LinearCache in DualLinearCache in direct dual path#1065
Merged
ChrisRackauckas merged 4 commits intoJun 29, 2026
Conversation
54f1480 to
9b21824
Compare
…e inference of whether dual_linear_cache field is nothing
9b21824 to
55e7f19
Compare
Contributor
Author
|
This is my best attempt for now. I think the problem was that The changes here make PureKLU keep using the direct AD path and makes it faster than KLU. #1066 instead moves PureKLU to the split AD path, which makes it only as fast as KLU. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A suggested fix to #1064. This is largely generated with Claude. I admittedly don't understand the internals well enough to know whether this is the right fix to make. Any help is appreciated :)
It fixes the original example in #1064 (comment), which now gives:
Now PureKLU is faster than KLU (as it should be?).