Propagate integration resolver failures#4759
Draft
ChrisRackauckas-Claude wants to merge 2 commits into
Draft
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResolverErrorcatches that converted incompatible environments into green jobs in both Downstream and ReleaseTestThis is stacked on #4755; review #4755 first. The branch was rebased onto current
upstream/masterbefore publishing.Local verification
Catalyst/Modelingrun with current ModelingToolkit and ModelingToolkitBase developed reached substantive tests and exited 1 on the already-triagedparent_sysfailure addressed by Catalyst#1509ModelingToolkitStandardLibrary/Corerun likewise reached substantive tests and exposed the existing failure addressed by MTSL#489actionlint .github/workflows/Downstream.yml .github/workflows/ReleaseTest.yml— passedjulia +1.12 -m Runic --check .— passedgit diff upstream/master...HEAD --check— passedThose test failures were already rethrown by the old handler. This PR specifically changes resolver incompatibilities from successful exits to visible job failures and intentionally does not hide legitimate downstream failures.
Please ignore this PR until it has been reviewed by @ChrisRackauckas.