Drop stale NaNMath 0.3 compatibility#4794
Merged
ChrisRackauckas merged 1 commit intoJul 20, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Investigation log:
The branch contains only commit |
Member
Author
|
CI triage for
The requested stale-major removal is green; the inspected red lanes are clean-base failures or runner infrastructure rather than regressions from this branch. |
ChrisRackauckas
marked this pull request as ready for review
July 20, 2026 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigation
NaNMath 1 has been available since 2022. I changed only the ModelingToolkitBase compat entry, regenerated the exact lower-bound graph, and ran the package's existing InterfaceI group with manifest re-resolution disabled.
The current QA group also reports the repository's existing Aqua failures (45 ambiguities and 14 piracy reports). A fresh clean-base reproduction is identical, and those failures are already tracked in #4670; no Aqua change is included here.
Local verification
GROUP=InterfaceI: 1,469 passed, 5 pre-existing brokenGROUP=InterfaceI julia +1.10 --project=lib/ModelingToolkitBase -e 'using Pkg; Pkg.test(; allow_reresolve=false)': 1,469 passed, 5 pre-existing brokencf431c15ea5c218371c4fe6f41ad96794aabdd0d407c1b62b7678ae84ea41bb1before and after the testIgnore this PR until it has been reviewed by @ChrisRackauckas.