Require SciMLTesting 1.2 for grouped test harness#4804
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Require SciMLTesting 1.2 for grouped test harness#4804ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Validation scratchpad for
No failing test was skipped, silenced, or loosened. |
Member
Author
|
Final exact-head CI classification for
None of the six failures is caused by the one-line SciMLTesting compat change. The branch remains one commit/one file, is zero commits behind current No test was skipped, silenced, or loosened. |
Member
|
Dropping all pre 2.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the rebased successor to #4790. GitHub would not reopen that closed PR after its head branch was force-updated onto current
master.Summary
1to1.22.1compatibility from Allow SciMLTesting v2.1 in QA envs #4758run_testsAPI adopted ind647d61ac4Why #4758 does not supersede this floor
Current
masterstill declaresSciMLTesting = "1, 2.1". Its root harness calls groupedrun_testswithout acorekeyword attest/runtests.jl:9. SciMLTesting 1.0.0 through 1.1.1 require that keyword, so every still-allowed 1.x resolution below 1.2 fails before any package test runs.An exact SciMLTesting 1.0 control on current
master(fb3706f352) reproduces:The 2.x QA migration makes current resolution work, but it does not repair the declared 1.x compatibility range. This PR changes that range from
1, 2.1to1.2, 2.1.Local validation after rebasing onto current master
GROUP=SymbolicIndexingInterface: 1,964/1,964 passedcorekeyword startup failure abovegit diff --check: passedmasterindentation defect fixed by Fix Runic indentation in parse_variable #4801; this PR changes onlyProject.tomlEarlier boundary probes also confirmed 1.0.0, 1.1.0, and 1.1.1 fail at harness startup while 1.2.0 is the first compatible release.