Skip to content

Run downgrade CI on pushes to main#494

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:agent/fix-downgrade-main-push-trigger
Jul 21, 2026
Merged

Run downgrade CI on pushes to main#494
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:agent/fix-downgrade-main-push-trigger

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Summary

  • run the Downgrade workflow after pushes to the repository's actual default branch, main
  • leave pull-request filtering, path filtering, the reusable workflow, and the downgrade configuration unchanged

Root cause

The repository moved from master to main, but the historical branch-reference update changed only the pull_request target in Downgrade.yml. The push target remained master, so merges to the default branch did not trigger the downgrade workflow.

Impact

Merged default-branch changes will again receive strict minimum-version coverage. This is a workflow-trigger-only change; it does not alter package behavior or dependency bounds.

Validation

  • actionlint -verbose .github/workflows/Downgrade.yml — exit 0, zero parse/rule errors
  • julia +1.12 --startup-file=no --project=../../audit/runic_env -m Runic --check --diff . — exit 0, no formatting diff
  • shell assertion over the push block — exactly one main target and no master target
  • git diff --check — exit 0

Package tests were not run because the only changed datum is a GitHub Actions event filter; the package source, tests, dependency bounds, and reusable downgrade job are untouched.

Known independent failure

An exact version-only run on clean main can expose the existing SISO initialization failure. Draft #491 addresses that package behavior separately. This PR neither hides that failure nor duplicates its fix.

Process

  • fetched the canonical repository and verified the authenticated fork's main is at the same commit (06464384)
  • inspected the workflow's full history and the prior canonical-CI PRs before editing
  • made the one-line change on a feature branch and pushed it without force

Ignore this PR until it has been reviewed by @ChrisRackauckas.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

Implementation scratchpad for commit a051ff76:

  1. Confirmed main is the repository default and compared the other push-triggered workflows, which already target main.
  2. Traced Downgrade.yml history: bc036599 updated the pull-request branch from master to main but left the push branch unchanged.
  3. Changed only that stale push branch; no package/test/compat or reusable-workflow settings changed.
  4. Ran actionlint (zero errors), Runic (no diff), an exact trigger assertion (main once, master absent), and git diff --check (clean).
  5. Did not run package tests because this event-filter edit cannot affect package execution. The known clean-main SISO failure remains isolated to test: exercise SISO initialization through ODEProblem #491 and was not skipped, silenced, or duplicated here.

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

CI classification after the first PR run:

No additional change belongs in this trigger-only PR: its new main push trigger executed as intended, and it neither causes nor masks the package/base failures above.

@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 21, 2026 21:15
@ChrisRackauckas
ChrisRackauckas merged commit 2366d99 into SciML:main Jul 21, 2026
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants