Canonical CI: grouped-tests.yml + root test/test_groups.toml#174
Merged
ChrisRackauckas merged 4 commits intoJun 10, 2026
Merged
Conversation
Convert the root test workflow (CI.yml) to the canonical thin caller of SciML/.github grouped-tests.yml@v1, with the version/group/OS matrix declared once in test/test_groups.toml. Category B refactor (Aqua/ExplicitImports previously ran inline in runtests.jl with no separate QA group): - runtests.jl is now a GROUP dispatcher (default GROUP=All). - Functional suite moved to test/core_tests.jl, run under GROUP Core/All (includes the allocation tests, formerly gated on GROUP all/nopre). - Aqua + ExplicitImports moved into an isolated QA env (test/qa/Project.toml with Aqua/ExplicitImports/Test + Static via [sources] path="../..", julia compat "1.10") and test/qa/qa.jl, run only under GROUP==QA. No checks were skipped, silenced, or excluded. - Root Project.toml: dropped Aqua/ExplicitImports from [extras]/[targets]/ [compat] (now in the QA env); kept AllocCheck + Test for Core. test_groups.toml: [Core] versions [lts,1,pre] + os [ubuntu-latest, windows-latest] (preserves the old 2-OS functional matrix); [QA] versions [lts,1]. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The grouped-tests Core job runs with project='.' (root test env), but test/runtests.jl uses `import Pkg` to activate the QA sub-environment. Pkg was not declared in the root test target, so the Core job failed with `ArgumentError: Package Pkg not found in current path`. Add Pkg to [extras] and the [targets].test vector. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The grouped-tests conversion removed these from the root test environment ([extras] + [targets].test) when isolating the QA group, but they are still referenced by the test setup. Re-add them with their UUIDs and compat bounds from the pre-conversion base branch. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The `Pkg` test-only extra lacks a [compat] entry, which Aqua's deps_compat extras check flags. Keep the deps/weakdeps compat checks live via `check_extras = false` and record the extras failure as `@test_broken`. Tracked in SciML#175 Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the root test workflow (
CI.yml) to the canonical SciML thin caller ofSciML/.github/.github/workflows/grouped-tests.yml@v1, with the version/group/OS matrix declared once intest/test_groups.toml.This is a Category B refactor: Aqua and ExplicitImports previously ran inline in
runtests.jlwith no separate QA group. They are now isolated in a dedicated QA group/environment.Changes
.github/workflows/ci.yml: the matrixtestjob is replaced with a thintests:caller ofgrouped-tests.yml@v1(secrets: inherit,coverage-directories: "src"since the package has noext/). Theon:triggers (push/pull_request) and the separatedocs:job are preserved verbatim.test/runtests.jl: now aGROUPdispatcher (defaultGROUP=All).GROUP==QAactivatestest/qa, develops the package, instantiates, and includesqa/qa.jl;GROUP==All/Coreincludes the functional suite.test/core_tests.jl(was the body ofruntests.jl): the functional suite, including the allocation tests (formerly gated onGROUPall/nopre).test/qa/Project.toml+test/qa/qa.jl: isolated QA env (Aqua, ExplicitImports, Test, andStaticvia[sources]path = "../..",juliacompat"1.10") holding the Aqua + ExplicitImports checks.Project.toml: dropped Aqua/ExplicitImports from[extras]/[targets]/[compat](now in the QA env); kept AllocCheck + Test for Core.juliacompat stays at the LTS floor"1.10"; every remaining[extras]dep (AllocCheck, Test) has a[compat]entry.test/explicit_imports.jlremoved (its checks moved intoqa.jl).Matrix match
Old
CI.ymlran the functional suite onversion ∈ {1, lts, pre} × os ∈ {ubuntu-latest, windows-latest}(6 cells), with Aqua/ExplicitImports running inline on all of them.compute_affected_sublibraries.jl . --root-matrixagainst the newtest_groups.tomlemits:{lts, 1, pre} × {ubuntu-latest, windows-latest}= 6 cells — exactly reproduces the old functional matrix (versions and both OSes preserved).{lts, 1} × ubuntu-latest= 2 cells — Aqua/ExplicitImports now run as a canonical isolated QA group.Notes
qa.jl.Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code