QA: restore Aqua deps_compat (add missing [compat] for test extras)#176
Merged
ChrisRackauckas merged 1 commit intoJun 13, 2026
Merged
Conversation
Adds the missing Pkg = "1" [compat] entry for the Pkg test extra in the root Project.toml, then restores the full Aqua.test_deps_compat call (drops check_extras=false and removes the @test_broken false sentinel) in the QA driver. This is the proper metadata fix for the self-inflicted regression. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Properly fixes the self-inflicted Aqua
deps_compatregression introduced during the grouped-tests CI conversion. The conversion addedPkgto[extras](for the QA driver) without a corresponding[compat]entry, then worked around the resulting Aqua failure by weakening the check (check_extras = false) plus a@test_broken falsesentinel and a tracking issue (#175) — instead of the one-line metadata fix.This PR does the actual fix:
Project.toml: adds the missingPkg = "1"[compat]entry (the only[extras]dependency that lacked one).test/qa/qa.jl: restores the fullAqua.test_deps_compat(Static)call (dropscheck_extras = false) and removes the@test_broken falsesentinel and its tracking comment. The unrelated, pre-existingAqua.test_piracies(Static, broken = true)marker is left untouched.Verification
Ran locally with
GROUP=QAon Julia 1.11 (Pkg.test()): the Aqua testset passes (9 pass / 1 broken — the pre-existing piracy marker — / 10 total) withtest_deps_compatfully enabled and nodeps_compat@test_brokensentinel. ExplicitImports passes 2/2. No new failures.Closes #175.
Ignore until reviewed by @ChrisRackauckas.