Use SciMLTesting v1.2 (folder-based run_tests)#177
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
ff9dee7 to
99109e8
Compare
Convert test/runtests.jl to the SciMLTesting v1.2 folder-discovery model: runtests.jl is now `using SciMLTesting; run_tests()`. Core = top-level test/core_tests.jl (which includes the ranges/alloc helpers); QA = test/qa/qa.jl with its existing sub-env Project.toml. ranges.jl and alloc_tests.jl are moved to test/shared/ (a non-group folder that folder-discovery never auto-runs) so they are not picked up as standalone Core files; core_tests.jl includes them from there. ranges.jl has no `using` of its own and relies on core_tests.jl's scope, so it must stay an include rather than a top-level Core file. Aqua/ExplicitImports/Pkg dropped from the root test deps (QA tools live in the test/qa sub-env; Pkg is owned by the harness; no test file uses it). SciMLTesting + SafeTestsets added to the root test deps and the QA sub-env. Behavior preserved: GROUP=Core/All runs core_tests.jl (2615 tests), GROUP=QA runs qa.jl (11 pass + 1 broken). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
99109e8 to
dc7c81d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
test/runtests.jlto the SciMLTesting v1.2 folder-discovery model.runtests.jlis now simply:Folder layout:
test/core_tests.jl(whichincludes the ranges/alloc helpers).test/qa/qa.jlwith its existing sub-envtest/qa/Project.toml.ranges.jlandalloc_tests.jlmoved totest/shared/(a non-group folder that folder-discovery never auto-runs) and included bycore_tests.jlfrom there.ranges.jlhas nousingof its own and relies oncore_tests.jl's scope, so it must remain anincluderather than a standalone top-level Core file (which folder-discovery would otherwise run on its own and fail).Dep edits:
Aqua/ExplicitImports/Pkgdropped from the root test deps (QA tools live in thetest/qasub-env;Pkgis owned by the harness; no test file uses it).SciMLTesting+SafeTestsetsadded to the root test deps and the QA sub-env.Behavior preserved (verified locally on Julia 1.11):
GROUP=Core/Allrunscore_tests.jl(2615 tests pass),GROUP=QArunsqa.jl(11 pass + 1 broken, the known piracy).Allruns Core only (QA excluded), matching the prior dispatch.test/test_groups.tomlunchanged.This supersedes and consolidates the earlier v1.0 rollout and the canonicalize-safetestset PR.
Ignore until reviewed by @ChrisRackauckas.