Skip to content

[Agentic] Address warnings in tests - part 1 (Phases 1 - 3)#7161

Draft
ukmo-ccbunney wants to merge 1 commit into
SciTools:mainfrom
ukmo-ccbunney:warnings-part1
Draft

[Agentic] Address warnings in tests - part 1 (Phases 1 - 3)#7161
ukmo-ccbunney wants to merge 1 commit into
SciTools:mainfrom
ukmo-ccbunney:warnings-part1

Conversation

@ukmo-ccbunney

Copy link
Copy Markdown
Contributor

Description

Unadulterated changes made by CoPilot running PR1 section of plan.md

@scitools-ci scitools-ci Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Templating

This PR includes changes that may be worth sharing via templating. For each file listed below, please either:

  • Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github templates/ directory. 1
  • Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
  • Dismiss the suggestion if the changes are not suitable for templating.

You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.

Template candidates

The following changed files are not currently templated, but their parent directories suggest they may be good candidates for a new template to be created:

Footnotes

  1. Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
    @scitools-templating: please no update notification on: iris

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (3f0dd8d) to head (88eb357).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7161   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files          91       91           
  Lines       24983    24985    +2     
  Branches     4685     4684    -1     
=======================================
+ Hits        22524    22526    +2     
  Misses       1682     1682           
  Partials      777      777           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pytestmark = pytest.mark.filterwarnings(
"ignore:.*regrid_conservative_via_esmpy.*:iris._deprecation.IrisDeprecation"
)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that the fix for this, as per the plan.md, was to use pytest.warns in the test.
However, the fix that has been applied is a blanked filterwarning at the module level...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants