Draft
Conversation
| todaysSoups: specials[id]?.soups ?? [], | ||
| todaysSpecials: specials[id]?.specials ?? [], | ||
| images: menuData?.images ?? [], | ||
| menuItemsString: menuData?.menuItemsString ?? "", |
There was a problem hiding this comment.
Bug: The menuItemsString field incorrectly returns "" instead of null for missing data, which violates the API's nullable schema definition.
Severity: MEDIUM
Suggested Fix
Change the nullish coalescing operator's fallback value from "" to null to align with the API schema. The line should be updated to menuItemsString: menuData?.menuItemsString ?? null. This ensures the API correctly signals the absence of data to clients.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/db/getLocations.ts#L57
Potential issue: The `getLocations` function incorrectly handles null values for the
`menuItemsString` field. It uses the nullish coalescing operator `?? ""` to convert
`null` values from the database into an empty string. However, the API schema explicitly
defines this field as nullable (`t.Nullable(t.String())`), and the data loading pipeline
intentionally stores `null` for missing data. This mismatch breaks the API contract, as
clients expecting `null` to signify "no data" will receive an empty string instead,
potentially leading to incorrect client-side logic.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The menu PNGs given by dining are now visible directly on cmueats. The items are all searchable and the locations serving those items will pop up. Search "lavender" for example will result in coffee shops showing up when it previously did not yield any results.