Conversation
…lback for Android binding
…en fixes - Add XCFramework download step in CI (ci.yml, publish-maui.yml) - Change <Content> to <None> for xcframework glob to avoid MSBuild processing binary framework files as build items (LocalDefiningProjectFullPath error) - Add using System; and [BaseType(typeof(NSObject))] to ApiDefinitions.cs - Add ScreebClassPtr.cs to provide missing class_ptr for bgen static class - Replace MainThread.InvokeOnMainThread → NSRunLoop.Main.BeginInvokeOnMainThread - Add NativeScreeb alias to resolve naming conflict in Screeb.iOS.cs - Gitignore native/ios binaries (downloaded at build time)
Replace 18x repeated TaskCompletionSource+dispatch+try/catch pattern with: - OnMain(Action) -> Task<bool?> for simple fire-and-forget calls - OnMain(Action<TCS<bool?>>) -> Task<bool?> for calls with custom result/cleanup - OnMain<T>(Action<TCS<T?>>) where T : class -> Task<T?> for reference-type results Android: 344 -> 184 lines (-46%) iOS: 325 -> 166 lines (-49%)
…ionsAsynchronously
… WithXxx pattern
…ix D8 duplicate class
- Switch InitSdk from PluginInit to InitSdk(Context, ...) so the SDK properly registers ActivityLifecycleCallbacks and can attach its WebView overlay to the active window (fixes 'null null' log) - Move Android init from OnStart() to OnResume() with _sdkInitialized guard so init runs after the Activity window is ready - Remove unused ToInitOptionsMap helper (replaced by native InitOptions) - Add BackgroundColor=White to MainPage to prevent grey/black screen
Without a MauiApplication subclass, the Android Application has no MauiContext and MauiAppCompatActivity cannot bootstrap the rendering pipeline, resulting in a grey/blank screen. Also revert PluginInit (was incorrectly changed to InitSdk) and restore ToInitOptionsMap helper. Revert OnResume back to OnStart.
- Add MainApplication.cs and minSdk 24 requirement for Android - Add AppDelegate.cs requirement for iOS - Show OnStart init pattern in App.xaml.cs - Add ScreebInitOptions and ScreebHooks usage examples - Add full API method reference table - Fix example README: net8.0 → net9.0, MauiProgram.cs → App.xaml.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.