Skip to content

migrate to new jaco-mp3 build #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riktenx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

migrate to new jaco-mp3 build #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ repositories {
def runeLiteVersion = 'latest.release'

dependencies {
implementation files('libs/jaco-mp3-player-0.9.5.jar')
implementation 'net.runelite:jaco-mp3-player:0.10.2-rl1'

compileOnly group: 'net.runelite', name:'client', version: runeLiteVersion

Expand Down
Binary file removed libs/jaco-mp3-player-0.9.5.jar
View file
Open in desktop
Binary file not shown.
6 changes: 3 additions & 3 deletions src/main/java/com/weather3d/audio/SoundPlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ public void playClip(SoundEffect soundEffect)
return;
}

trackPlayer.getPlayList().clear();
trackPlayer.clearPlayList();
handlePlayThread = new Thread(() -> {
try
{
String soundLink = soundEffect.getSoundFile();
if (soundLink.toLowerCase().startsWith("http"))
trackPlayer.addToPlayList(new URL(soundLink));
trackPlayer.add(new URL(soundLink));
else
trackPlayer.addToPlayList(new File(soundLink)); //this is here for local testing
trackPlayer.add(new File(soundLink)); //this is here for local testing
trackPlayer.play();
}
catch (Exception e)
Expand Down