[codex] collect per-generation parsing errors#190
Draft
Ki-Seki wants to merge 2 commits into
Draft
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
error_mode="raise" | "collect"to synchronous, asynchronous, and vLLM offline batch model interfacesGenerationResultto preserve each raw response together with either its parsedResultor serializable error detailserror_modeis omittedRoot cause
Multi-candidate and batch responses were passed through list-level infill helpers. A parsing exception from one generated string aborted the conversion of the entire response list, discarding otherwise valid candidates and queries.
Behavior
error_mode="raise"remains the default and preserves fail-fast behavior.error_mode="collect"parses every generated string independently.Resultelements withGenerationResultelements.Validation
uv run pytest— 73 passeduv run mypy src— passeduv run ruff format src tests— passeduv run ruff check src tests— passed