Skip to content

Refactor#1034

Merged
tyt2y3 merged 1 commit intoSeaQL:masterfrom
Huliiiiii:array-try-from
Apr 8, 2026
Merged

Refactor#1034
tyt2y3 merged 1 commit intoSeaQL:masterfrom
Huliiiiii:array-try-from

Conversation

@Huliiiiii
Copy link
Copy Markdown
Member

No description provided.

Comment thread src/value/array.rs Outdated
#[cfg(feature = "with-mac_address")]
Array::MacAddress(v) => v.is_empty(),
Array::Null(_) => true,
Array::Null(_) => false,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm Null should be empty right?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the is_null method.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty array => '{}'
null array => NULL

@Huliiiiii Huliiiiii changed the title Add missing Array::Null to try_from_value Refactor Dec 28, 2025
@Huliiiiii Huliiiiii requested a review from tyt2y3 December 28, 2025 23:55
@tyt2y3 tyt2y3 merged commit 239cf43 into SeaQL:master Apr 8, 2026
27 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

🎉 Released In 1.0.0-rc.33 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants