Generate invalid sql for IndexCreateStatement::cond_where on MySQL …#1067
Open
Huliiiiii wants to merge 1 commit intoSeaQL:masterfrom
Open
Generate invalid sql for IndexCreateStatement::cond_where on MySQL …#1067Huliiiiii wants to merge 1 commit intoSeaQL:masterfrom
IndexCreateStatement::cond_where on MySQL …#1067Huliiiiii wants to merge 1 commit intoSeaQL:masterfrom
Conversation
…instead of silently ignoring it
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6414c2e89d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Expurple
reviewed
Apr 16, 2026
Member
Expurple
left a comment
Expurple
left a comment
There was a problem hiding this comment.
I would explicitly document on those methods why we intentionally generate invalid SQL for MySQL, and reference the issue.
The decision itself is OK to me. Probably makes more sense to crash the query, than to crash the entire app with a panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1066