Conversation
| #[cfg(feature = "postgres-array")] | ||
| Value::Array(ty, _) => array_type_to_pg_type(ty), | ||
| #[cfg(feature = "postgres-vector")] | ||
| Value::Vector(_) => todo!(), |
There was a problem hiding this comment.
I guess this is the reason it is still WIP?
for non built-in types I think there is no way we can statically know the type id.
which mean we need to make this function fallible (return Result) sad
There was a problem hiding this comment.
Yes. Perhaps we could allow users to specify the pgvector return type through a parameter.
| #[cfg(feature = "postgres-array")] | ||
| Value::Array(ty, _) => array_type_to_pg_type(ty), | ||
| #[cfg(feature = "postgres-vector")] | ||
| Value::Vector(_) => todo!(), |
There was a problem hiding this comment.
How to handle the mapping of pgvector?
| #[cfg(feature = "postgres-array")] | ||
| Value::Array(ty, _) => array_type_to_pg_type(ty), | ||
| #[cfg(feature = "postgres-vector")] | ||
| Value::Vector(_) => todo!(), |
There was a problem hiding this comment.
Yes. Perhaps we could allow users to specify the pgvector return type through a parameter.
|
I totally don't know that reviews need to be submitted first |
🎉 Released In 1.0.0-rc.33 🎉Thank you everyone for the contribution! |
3 participants
New Features
as_typestoPostgresValues