Fix LIKE and NOT LIKE Queries for Strings#162
Open
jsievenpiper wants to merge 1 commit into
Open
Conversation
Collaborator
|
Fantastic work, @jsievenpiper, thanks for showing interest in the project and improving it. |
Collaborator
|
@jsievenpiper regarding the broken tests I am trying to deal with it at #161 |
tyt2y3
force-pushed
the
main
branch
2 times, most recently
from
2de933f to
d24a975
Compare
tyt2y3
force-pushed
the
main
branch
16 times, most recently
from
5801629 to
f19754c
Compare
tyt2y3
force-pushed
the
main
branch
7 times, most recently
from
4e9008c to
ff350b4
Compare
tyt2y3
force-pushed
the
main
branch
2 times, most recently
from
a33e7eb to
7bced3d
Compare
tyt2y3
force-pushed
the
main
branch
4 times, most recently
from
a9b503f to
6b1ff0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
This is a quick patch that fixes LIKE and NOT LIKE queries, which as far as I can tell, have never worked in seaography. The underlying
sea_ormcode works, but when stringifying the already String value, sea_orm quotes the value (presumably to prevent SQL injection?).In other query filters, the filter conditions take a
sea_orm::Valuedirectly, which seems to do the correct thing (I didn't look that deeply at it, buteqworks, for example). However, anything based onLIKEstyle queries (starts with, etc) takeStringinputs. If pulling the string from asea_orm::Value::to_stringcall, you'll end up with a double-quoted string:Which then fails to actually match anything.
N/A
N/A
New Features
N/A
Bug Fixes
Breaking Changes
N/A
Changes
N/A