seattlecolleges.github.io_issue#122_add-rae-maffei-to-students#129
Conversation
Added new student entry for Rae Maffei with details.
|
light flag on this PR for naming convention , please check documentation below https://github.com/SeattleColleges/SeattleColleges-AD-Practicum-Wiki/wiki/draft-and-regular-prs |
|
Hi @givecoffee! Is this PR meant to be in draft or is it ready to be merged? You have all the basic required data for the student's page added, but I didn't see you include a profile picture in the image asset folder. If you are ok with the anon profile pick, let me know and I can get this merged |
|
I also placed the PR into a draft for now. Open it back up for merging if you are done with the PR. |
sstar691969
left a comment
There was a problem hiding this comment.
students.json code or developer profile looks good. brackets and commas look greated. no errors from my view. If your having issue with profile photo BC shared that profile photo is not needed currently to move forward on submitting.
|
Attention: your PR is in "Drafted" as mentioned by IssacJrType. |
|
@givecoffee Once you are ready, can you turn this into ready state? |
bcko
left a comment
There was a problem hiding this comment.
Great job. Make sure to turn your PR from draft to ready.
IsaacJrTypes
left a comment
There was a problem hiding this comment.
Great work on this PR, thank you for properly filling out the PR description!
|
Anything else to do?
…On Thu, Mar 26, 2026, 4:22 PM Isaac J ***@***.***> wrote:
Merged #129
<#129>
into main.
—
Reply to this email directly, view it on GitHub
<#129?email_source=notifications&email_token=AV2DIJVGVLN7AXLUYJGIPJ34SW3UDA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEMZZGUZTEMBZG43THJTSMVQXG33OU5RW63LNMVXHJJLFOZSW45FMMZXW65DFOJPWG3DJMNVQ#event-23953209773>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV2DIJSD6VZFNOHCCOXZGFL4SW3UDAVCNFSM6AAAAACU3DCDUOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRTHE2TGMRQHE3TOMY>
.
You are receiving this because you commented.Message ID:
<SeattleColleges/seattlecolleges.github.
***@***.***>
|
Added new student entry for Rae Maffei with details.
Summary & Changes 📃
Resolves: Students Page: Add yourself to the Students Page #122
Summary: (Briefly describe what this PR does)
src/students.jsonHow to Test 🧪
src/students.jsonhas valid JSON syntaxChecklist ✅
Resolves #issue-number).