seattlecolleges.github.io_0_122_Add student name to list of students#142
Open
endlesslupita wants to merge 5 commits intoSeattleColleges:mainfrom
Open
Conversation
Photo not uploaded yet.
SUPER444E
requested changes
Mar 7, 2026
Contributor
There was a problem hiding this comment.
Looks like your append did not get put to the end of the list, do you mind following up on this and fix this?
Contributor
There was a problem hiding this comment.
@endlesslupita , can you take a look at this? If you update your PR, make sure to resolve this conversation.
|
The format of the .json file looks good. I think you just have to resolve the conflicts in your branch and it should be good. |
bcko
approved these changes
Mar 20, 2026
Contributor
bcko
left a comment
bcko
left a comment
There was a problem hiding this comment.
I will approve this PR with the condition that you will resolve the PR comment provided by @SUPER444E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Changes 📃
Resolves: Students Page: Add yourself to the Students Page #122
Summary:
Changes: