Skip to content

Update students.json#155

Draft
DennizGarza1234 wants to merge 3 commits intoSeattleColleges:mainfrom
DennizGarza1234:patch-1
Draft

Update students.json#155
DennizGarza1234 wants to merge 3 commits intoSeattleColleges:mainfrom
DennizGarza1234:patch-1

Conversation

@DennizGarza1234
Copy link
Copy Markdown

@DennizGarza1234 DennizGarza1234 commented Mar 2, 2026

Summary & Changes 📃

  • Resolves: Students Page: Add yourself to the Students Page #122

  • Summary: (Briefly describe what this PR does)
    This PR adds the student profile for Denniz Garza to the Students page

  • Adds Denniz Garza's information to the students list

  • The student profile appears correctly on the Students page

  • This changes the project guidelines for adding student entries

  • Changes:

Screenshots / Visual Aids 🔎

📌 Required for: UI changes, layout updates, or bug fixes.

Expand ⬇️

How to Test 🧪

  1. Steps to Reproduce:
    • Step 1: Pull this branch
    • Step 2: Run 'npm install'
    • Step 3: Run 'npm run dev'
    • Step 4: Navigate to the Students page
  2. Expected Behavior:
    Denniz Garza's profile appears at the end of the Students list with correct information and image
  3. Actual Behavior (if bug):
    N/A

Checklist ✅

  • I have tested this PR locally and it works as expected.
  • This PR resolves an issue (Resolves #issue-number).
  • Reviewers, assignees(self), tags, and labels are correctly assigned.
  • Squash commits and enable auto-merge if approved.

@DennizGarza1234
Copy link
Copy Markdown
Author

I am pulling this to #122

Copy link
Copy Markdown
Contributor

@makayo makayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON entry looks correct. Approving.

@makayo
Copy link
Copy Markdown
Contributor

makayo commented Mar 6, 2026

The JSON looks good. This PR just needs merge conflicts resolved before it can be merged.

Copy link
Copy Markdown
Contributor

@IsaacJrTypes IsaacJrTypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DennizGarza1234, there a couple small thing you will need to change in this PR for me to merge it.

  1. Check your student data object entry
  2. If you do not want to include a personal image, please use "anon-profile-image.webp" as the value for the photo property.

Don't worry about the merge conflicts, I can handle that part. Lastly, feel free to reach out to me on slack if you need help!

Comment thread src/students.json
@IsaacJrTypes IsaacJrTypes marked this pull request as draft March 7, 2026 00:13
@IsaacJrTypes
Copy link
Copy Markdown
Contributor

I placed this PR into a draft for now until the changes are met. Also, please fill out the summary and changes section. If you need guidance on how to fill it out, I recommend checking out other PRs that have been merged. The reason we fill out the PR with details is that we can get context on what this PR solves. While this task seems straight forward, in more complex tasks/projects, the details serve as a form of documentation. It's part of the developers workflow to provide as much detail that are necessary for other developers to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants