Conversation
|
I am pulling this to #122 |
makayo
left a comment
There was a problem hiding this comment.
The JSON entry looks correct. Approving.
|
The JSON looks good. This PR just needs merge conflicts resolved before it can be merged. |
There was a problem hiding this comment.
Hi @DennizGarza1234, there a couple small thing you will need to change in this PR for me to merge it.
- Check your student data object entry
- If you do not want to include a personal image, please use
"anon-profile-image.webp"as the value for the photo property.
Don't worry about the merge conflicts, I can handle that part. Lastly, feel free to reach out to me on slack if you need help!
|
I placed this PR into a draft for now until the changes are met. Also, please fill out the summary and changes section. If you need guidance on how to fill it out, I recommend checking out other PRs that have been merged. The reason we fill out the PR with details is that we can get context on what this PR solves. While this task seems straight forward, in more complex tasks/projects, the details serve as a form of documentation. It's part of the developers workflow to provide as much detail that are necessary for other developers to review. |
Summary & Changes 📃
Resolves: Students Page: Add yourself to the Students Page #122
Summary: (Briefly describe what this PR does)
This PR adds the student profile for Denniz Garza to the Students page
Adds Denniz Garza's information to the students list
The student profile appears correctly on the Students page
This changes the project guidelines for adding student entries
Changes:
Screenshots / Visual Aids 🔎
📌 Required for: UI changes, layout updates, or bug fixes.
Expand ⬇️
How to Test 🧪
Denniz Garza's profile appears at the end of the Students list with correct information and image
N/A
Checklist ✅
Resolves #issue-number).