Skip to content

Update students.json#158

Open
amdemw206-coder wants to merge 6 commits intoSeattleColleges:mainfrom
amdemw206-coder:add-student-amde-wubshet
Open

Update students.json#158
amdemw206-coder wants to merge 6 commits intoSeattleColleges:mainfrom
amdemw206-coder:add-student-amde-wubshet

Conversation

@amdemw206-coder
Copy link
Copy Markdown

@amdemw206-coder amdemw206-coder commented Mar 3, 2026

Summary & Changes 📃

  • Resolves: Students Page: Add yourself to the Students Page #122

  • Summary:

    • 🔨 What does this issue fix? This Pull Request adds my student profile for the NSC application development website.
    • 👀 What is the expected behavior? To display on the "students" section of the NSC application development website.
    • 🗨️ Any relevant technical details? None.
  • Changes:

    • ✅ Added student profile "Amde Wubshet" to src/students.json

Screenshots / Visual Aids 🔎

📌 Required for: UI changes, layout updates, or bug fixes.

Expand ⬇️ image

How to Test 🧪

  1. Steps to Reproduce:
    • Step 1: After cloning the repository & installing dependencies, run a local development server to view the website in your browser.
    • Step 2: In the src folder, open the students.json file.
    • Step 3: Scroll to the end of the file and input information for student Amde Wubshet.
  2. Expected Behavior: Displays the student information on the site.

Checklist ✅

  • I have tested this PR locally and it works as expected.
  • This PR resolves an issue (Resolves #issue-number).
  • Reviewers, assignees(self), tags, and labels are correctly assigned.
  • Squash commits and enable auto-merge if approved.

Comment thread src/students.json
Copy link
Copy Markdown
Contributor

@sstar691969 sstar691969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

students.json code has no error and bracket was correct and fixed.

Image

@PaulinaS123
Copy link
Copy Markdown
Contributor

Hi, I reviewed the pull request and the failing check is likely caused by an issue in the students.json file format.

The GitHub action “Sync Project Status / sync-status” usually fails when the JSON structure does not exactly match the required format for the project. Please double-check the following:

  1. Make sure all required fields are included (name, program, image, github, linkedin, email, bio).
  2. Verify that commas are placed correctly between fields and that there is no extra comma at the end of the object.
  3. Confirm that all quotation marks and brackets are properly closed.
  4. Check that the image path matches a file that actually exists in the images folder.
  5. Ensure the new student entry follows the same structure as the existing entries in students.json.

After fixing the JSON formatting, commit the changes and push again so the check can rerun.

Once the sync-status check passes, the pull request should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants