seattlecolleges.github.io_ 122_add_student_william_anderson#163
seattlecolleges.github.io_ 122_add_student_william_anderson#163sstar691969 merged 4 commits intomainfrom
Conversation
added new update on profile
Added LinkedIn.com link
|
The JSON entry for William Anderson looks correct and the PR is ready for a second approval when maintainers have time. |
makayo
left a comment
makayo
left a comment
There was a problem hiding this comment.
The JSON entry for William Anderson looks correct and the PR is ready for a second approval when maintainers have time.
|
Hi @sstar691969, can you fill out the summary and changes section. I highly recommend to check out PRs that have been merged. Its good practice to give more detail information about the pull request. Once tasks get more complex, the detail serves as documentation. Great job overall! Don't worry about the merge conflicts, I will take care of that! |
SUPER444E
left a comment
SUPER444E
left a comment
There was a problem hiding this comment.
Your code looks good and is ready to merge!, but first please update your PR description so it accurately describes what this PR does and what instructions we can do to replicate it, feel free to check other PRs like Isacc said, I'll be back to approve changes when It's updated
Thanks!
There was a problem hiding this comment.
It looks like this work was based on an older version of the main file. Before making changes, it’s best to pull the latest updates so you’re working from the most current version. Other students have already submitted and merged changes ahead of you, so your branch is out of date.
I recommend copying the code you wrote, updating your branch with the latest main, and then pasting your changes into the updated files.
And make sure to add a photo of you in as well. You will need to use https://squoosh.app/editor to compress the photo with webp effort 4 quality 75 so that it doesn't take much space.
This is a new update: March 8, 2026 |
Please give me an updated: BC said a profile photo is not necessary . |
|
Your code looks good, and everything worked as expected. However, there are still conflicts that need to be resolved before a new review and approval can be completed. You have two options:
Tip: You don’t need to copy your code into a separate text file, you can use git stash (docs |
I added comma to ( }, ) You may require for me to push to repository instead.
|
The web editor is confusing. How do I make change or add a comma after }, ? |
|
I finally complete the web editor issue.... I added ( }, ) and ( { ). |
SUPER444E
left a comment
SUPER444E
left a comment
There was a problem hiding this comment.
Looks all good! Thanks for the quick work.
|
My first approve pull request by a professional.... let's party (-:
…On Mon, Mar 9, 2026, 2:42 AM SUPER444E ***@***.***> wrote:
***@***.**** approved this pull request.
Looks all good! Thanks for the quick work.
—
Reply to this email directly, view it on GitHub
<#163 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV2DIJTBQBBAHRWSABQ2F2D4P2N3BAVCNFSM6AAAAACWJCHJVSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSMJUGE2DQMRSGU>
.
You are receiving this because you were mentioned.Message ID:
<SeattleColleges/seattlecolleges.github.io/pull/163/review/3914148225@
github.com>
|
|
Please check to see if I resolve this issue, I actually use web editor.
recently.
…On Sun, Mar 8, 2026 at 11:59 PM Violet Nguyen ***@***.***> wrote:
*itsvee0120* left a comment
(SeattleColleges/seattlecolleges.github.io#163)
<#163 (comment)>
Your code looks good, and everything worked as expected. However, there
are still conflicts that need to be resolved before a new review and
approval can be completed. You have two options:
1. Resolve the conflicts using the web editor, or
2. Merge main into your local branch and resolve the conflicts locally.
It looks like this work was based on an older version of the main file.
Before making changes, it’s best to pull the latest updates so you’re
working from the most current version. Other students have already
submitted and merged changes ahead of you, so your branch is out of date. I
recommend copying the code you wrote, updating your branch with the latest
main, and then pasting your changes into the updated files. And make sure
to add a photo of you in as well. You will need to use
https://squoosh.app/editor <http://url> to compress the photo with webp
effort 4 quality 75 so that it doesn't take much space.
Tip: You don’t need to copy your code into a separate text file, you can
use git stash (docs <https://git-scm.com/docs/git-stash>
). After stashing, merge main to update your branch, then apply the
stashed changes back. Alternatively, you can resolve the conflicts manually
line by line. It doesn’t seem like a very large conflict, so either method
should work fine.
—
Reply to this email directly, view it on GitHub
<#163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV2DIJSWJDZNSIT5EYO3NHL4PZ2W5AVCNFSM6AAAAACWJCHJVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMRRGU3DSMBSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
IsaacJrTypes
dismissed
LiteWilliamNguyen’s stale review
Will addressed all issues
6 participants
seattlecolleges.github.io_ 122_add_student_william_anderson
#122
Summary & Changes 📃
Regarding students.json updated changes to William Anderson's profile: added a ( }, ).
I had did npm run test and npm run start or npm start to check local 3000. Also added personal
developers profile with student email and Linkeln profile and shared role detail information.
#122
Pull requested: you send updated changes or added changes related to student.json and run code in
terminal then local 3000 to see if your profile image and information is shown in browser with out errors and the you submitted to projected team members to check to see if every steps is corrected. ifso then submitted to main branch to be live. So now all developers as completed the first Phase 1.
Screenshots / Visual Aids:
📌 Required for: UI changes, layout updates, or bug fixes.
Details
Image or profile uploaded with zero errors. Note I will uploaded a image soon.
Checklist ✅