Skip to content

seattlecolleges.github.io_issue#122_add_student_Edgar_Vargas#164

Merged
IsaacJrTypes merged 5 commits intomainfrom
add-student-Edgar-Vargas
Mar 27, 2026
Merged

seattlecolleges.github.io_issue#122_add_student_Edgar_Vargas#164
IsaacJrTypes merged 5 commits intomainfrom
add-student-Edgar-Vargas

Conversation

@EdgarShay
Copy link
Copy Markdown
Contributor

@EdgarShay EdgarShay commented Mar 9, 2026

Summary & Changes 📃

  • Resolves: #issue-number
    Resolves: Issue Students Page: Add yourself to the Students Page #122 — contributor profile addition

  • Summary: (Briefly describe what this PR does)

    • 🔨 What does this issue fix?
    • 👀 What is the expected behavior?
    • 🗨️ Any relevant technical details?
      This pull request adds my contributor profile to the repository as part of the onboarding process.
      Adds my personal information to the project
      Ensures my profile displays correctly with all required fields
      No functional or breaking changes; this update is limited to static content
  • Changes:

    • ✅ List key changes made
    • 🛠️ Mention breaking changes (if any)
    • 🔗 Link relevant discussions/issues
    • 📝 Additional info to assist developers & reviewers
      • Added my profile image
      • Added my full name
      • Added my email address
      • Added my GitHub profile link
      • Added a short description of my career goals
      • Updated the contributor/profile section accordingly
      • No breaking changes or dependency updates

Screenshots / Visual Aids 🔎

📌 Required for: UI changes, layout updates, or bug fixes.

Expand ⬇️

How to Test 🧪

  1. Steps to Reproduce:
    • Step 1: ...
    • Step 2: ...
  2. Expected Behavior: (Describe what should happen)
  3. Actual Behavior (if bug): (Describe what happens instead)
    How to Test
    Steps to Reproduce:
    Pull this branch locally
    Navigate to the contributors/profile section
    Verify that my image, name, email, GitHub link, and career goal description appear correctly
    Expected Behavior: My contributor profile should display cleanly with correct formatting and no errors.
    Actual Behavior (if bug): N/A — no issues identified.

Checklist ✅

  • [ x] I have tested this PR locally and it works as expected.
  • [x ] This PR resolves an issue (Resolves #issue-number).
  • [x ] Reviewers, assignees(self), tags, and labels are correctly assigned.
  • [x ] Squash commits and enable auto-merge if approved.

Copy link
Copy Markdown
Contributor

@IsaacJrTypes IsaacJrTypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this Edgar! I recommend that you use bullet points and organize the information in your PR writeup. I am specifically talking about the how to test section.

Check out this website to practice writing using markdown

@IsaacJrTypes IsaacJrTypes disabled auto-merge March 27, 2026 00:21
@IsaacJrTypes
Copy link
Copy Markdown
Contributor

IsaacJrTypes commented Mar 27, 2026

I just noticed that the image you uploaded might be too small. It breaks the overall design. For now I will add an the anonymous profile pic. If you want to add an image, you will have to provide a larger image that does not break the design.

CleanShot 2026-03-26 at 17 27 31

You can add an updated profile pic in a later PR.

@IsaacJrTypes IsaacJrTypes merged commit b17e284 into main Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants