Skip to content

Add student victoria salomon#165

Merged
IsaacJrTypes merged 3 commits intoSeattleColleges:mainfrom
PaulinaS123:add-student-victoria-salomon
Mar 26, 2026
Merged

Add student victoria salomon#165
IsaacJrTypes merged 3 commits intoSeattleColleges:mainfrom
PaulinaS123:add-student-victoria-salomon

Conversation

@PaulinaS123
Copy link
Copy Markdown
Contributor

@PaulinaS123 PaulinaS123 commented Mar 10, 2026

Summary & Changes 📃

Summary

This pull request adds my student profile to the Students section of the website.

  • 🔨 Adds a new student entry to src/students.json.
  • 👀 The expected behavior is that my profile appears at the end of the Students list on the website.
  • 🗨️ The entry includes my name, photo, role, about description, email, GitHub, and LinkedIn information.

Changes

  • ✅ Added new student entry for Victoria Salomon in src/students.json
  • ✅ Uploaded profile photo Paulina-Salomon.webp to src/images/students/
  • 🔗 Related issue: Students Page: Add yourself to the Students Page #122
  • 📝 Followed repository rules by adding the entry at the end of the list without modifying other students.

Screenshots / Visual Aids 🔎

Expand ⬇️

Student profile entry added to the students.json file and profile image uploaded to the students images folder.

Screenshot 2026-03-09 at 9 18 22 PM Screenshot 2026-03-09 at 9 23 39 PM

How to Test 🧪

  1. Steps to Reproduce

    • Step 1: Run the website locally.
    • Step 2: Navigate to the Students page.
    • Step 3: Scroll to the bottom of the list.
  2. Expected Behavior

    • The new student profile Victoria Salomon should appear at the end of the Students list with the correct information and photo.
  3. Actual Behavior

    • The student profile displays correctly with the provided details.

Checklist ✅

  • I have tested this PR locally and it works as expected.
  • This PR resolves an issue (Resolves #122).
  • Reviewers, assignees(self), tags, and labels are correctly assigned.
  • Squash commits and enable auto-merge if approved.

@IsaacJrTypes IsaacJrTypes self-requested a review March 26, 2026 23:40
Copy link
Copy Markdown
Contributor

@IsaacJrTypes IsaacJrTypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR! PR write up is clear and concise with visual aids. One thing I would suggest is to provide a screenshot of the application GUI with your changes over the code itself. File changes tabs produce the same data you provided with the visuals. Otherwise, good job!

@IsaacJrTypes IsaacJrTypes merged commit 99e39ce into SeattleColleges:main Mar 26, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants