Add Michael Tamirat to students.json#166
Add Michael Tamirat to students.json#166Mtamirat wants to merge 3 commits intoSeattleColleges:mainfrom
Conversation
There was a problem hiding this comment.
The runtime error is happening because the image file in the folder doesn’t match the filename specified in the field inside .
To fix this, update the image file in so that its name exactly matches the value used in for that student in . Once the filenames are consistent, the page will load correctly.
And make sure to delete the unnecessary image file.
|
I agree with @LiteWilliamNguyen, the fix is pretty quick. Simply change the naming convention, remove the extra image file, and make sure you convert any jpeg image to webp. The reason we ask you to convert this page is to convert to webp is because of the file size. JPEG's file size is larger than an webp file size. So having multiple image load at once will cause performance issues from the user's side because it is downloading all the image assets. User's don't have the patients for slow loading websites. |
Summary & Changes 📃
Resolves: #issue #122
Summary:
This PR adds my student profile to the
students.jsonfile for the Students section of the website.Changes:
Screenshots / Visual Aids 🔎
Not required for this change.
How to Test 🧪
Expected Behavior:
My profile appears correctly with my information and image.
Checklist ✅