Skip to content

Add Michael Tamirat to students.json#166

Open
Mtamirat wants to merge 3 commits intoSeattleColleges:mainfrom
Mtamirat:main
Open

Add Michael Tamirat to students.json#166
Mtamirat wants to merge 3 commits intoSeattleColleges:mainfrom
Mtamirat:main

Conversation

@Mtamirat
Copy link
Copy Markdown

@Mtamirat Mtamirat commented Mar 10, 2026

Summary & Changes 📃

Resolves: #issue #122

Summary:
This PR adds my student profile to the students.json file for the Students section of the website.

Changes:

  • Added Michael Tamirat to the students list
  • Included role, about description, GitHub, LinkedIn, and email
  • Uploaded profile image

Screenshots / Visual Aids 🔎

Not required for this change.

How to Test 🧪

  1. Navigate to the Students section of the website.
  2. Confirm that "Michael Tamirat" appears in the students list.
  3. Verify the profile image and links display correctly.

Expected Behavior:
My profile appears correctly with my information and image.

Checklist ✅

  • I have tested this PR locally.
  • This PR resolves an issue.
  • Reviewers, assignees, tags, and labels are correctly assigned.

Copy link
Copy Markdown
Contributor

@LiteWilliamNguyen LiteWilliamNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runtime error is happening because the image file in the folder doesn’t match the filename specified in the field inside .
To fix this, update the image file in so that its name exactly matches the value used in for that student in . Once the filenames are consistent, the page will load correctly.
And make sure to delete the unnecessary image file.

Image

@IsaacJrTypes
Copy link
Copy Markdown
Contributor

I agree with @LiteWilliamNguyen, the fix is pretty quick.

Simply change the naming convention, remove the extra image file, and make sure you convert any jpeg image to webp. The reason we ask you to convert this page is to convert to webp is because of the file size. JPEG's file size is larger than an webp file size. So having multiple image load at once will cause performance issues from the user's side because it is downloading all the image assets. User's don't have the patients for slow loading websites.

Here is a webp converter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants