Skip to content

add Livan Hagi Osman to Students Page#167

Merged
IsaacJrTypes merged 2 commits intomainfrom
add-student-livan-hagi-osman
Mar 27, 2026
Merged

add Livan Hagi Osman to Students Page#167
IsaacJrTypes merged 2 commits intomainfrom
add-student-livan-hagi-osman

Conversation

@livanho
Copy link
Copy Markdown
Contributor

@livanho livanho commented Mar 17, 2026

seattlecolleges.github.io_122_add-livan-hagi-osman-to-students-page

Summary & Changes 📃

  • Resolves: Students Page: Add yourself to the Students Page #122

  • Summary: Adds Livan Hagi Osman to the Students page data source so the new student profile appears in the UI.

  • What this fixes: Missing student entry for Livan Hagi Osman in the students dataset.

  • Expected behavior: The Students page shows Livan Hagi Osman with name, role, about text, email, GitHub, and LinkedIn.

  • Technical details: Data-only update in students.json by appending a new student object; no component logic changes.

  • Changes:

  • ✅ Added new student object with fields: name, photo, role, about, email, github, linkedin.

  • 🛠️ Breaking changes: None.

  • 🔗 Related issue/discussion: Students Page: Add yourself to the Students Page #122.

  • 📝 Reviewer notes: Please verify link targets and card rendering on the Students page.

Screenshots / Visual Aids 🔎

📌 Required for: UI changes, layout updates, or bug fixes.

Expand ⬇️

add-livan

How to Test 🧪

  1. Steps to Reproduce:
  • Step 1: Run npm install
  • Step 2: Run npm run start
  • Step 3: Open http://localhost:3000/students
  • Step 4: Find Livan Hagi Osman in the student list
  • Step 5: Verify email, GitHub, and LinkedIn links are present and correct
  1. Expected Behavior: The new student profile is visible and all details render correctly.
  2. Actual Behavior (if bug): Before this change, this student profile was not listed.

Checklist ✅

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new student entry to the site’s students.json dataset so that “Livan Hagi Osman” appears on the Students page UI (per Issue #122).

Changes:

  • Appended a new student object to src/students.json with name, photo, role, about, email, GitHub, and LinkedIn fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@amdemw206-coder
Copy link
Copy Markdown

Looks good! Was just reviewing this request because the sync-status check failing is preventing my pull request from merging. Hopefully, referencing this request will make my merge successful.

Copy link
Copy Markdown
Contributor

@IsaacJrTypes IsaacJrTypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the PR write up! Everything looks good here.

@IsaacJrTypes IsaacJrTypes merged commit a64ea36 into main Mar 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Students Page: Add yourself to the Students Page

4 participants