add Livan Hagi Osman to Students Page#167
Merged
IsaacJrTypes merged 2 commits intomainfrom Mar 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new student entry to the site’s students.json dataset so that “Livan Hagi Osman” appears on the Students page UI (per Issue #122).
Changes:
- Appended a new student object to
src/students.jsonwith name, photo, role, about, email, GitHub, and LinkedIn fields.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
Looks good! Was just reviewing this request because the sync-status check failing is preventing my pull request from merging. Hopefully, referencing this request will make my merge successful. |
IsaacJrTypes
approved these changes
Mar 27, 2026
Contributor
IsaacJrTypes
left a comment
There was a problem hiding this comment.
Great job on the PR write up! Everything looks good here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seattlecolleges.github.io_122_add-livan-hagi-osman-to-students-page
Summary & Changes 📃
Resolves: Students Page: Add yourself to the Students Page #122
Summary: Adds Livan Hagi Osman to the Students page data source so the new student profile appears in the UI.
What this fixes: Missing student entry for Livan Hagi Osman in the students dataset.
Expected behavior: The Students page shows Livan Hagi Osman with name, role, about text, email, GitHub, and LinkedIn.
Technical details: Data-only update in students.json by appending a new student object; no component logic changes.
Changes:
✅ Added new student object with fields: name, photo, role, about, email, github, linkedin.
🛠️ Breaking changes: None.
🔗 Related issue/discussion: Students Page: Add yourself to the Students Page #122.
📝 Reviewer notes: Please verify link targets and card rendering on the Students page.
Screenshots / Visual Aids 🔎
📌 Required for: UI changes, layout updates, or bug fixes.
Expand ⬇️
How to Test 🧪
Checklist ✅