Skip to content

feat(ts): opt-in import_style=modules and oneof_style=discriminated for TS generators#198

Closed
hishamank wants to merge 4 commits into
mainfrom
feat/ts-import-style-modules
Closed

feat(ts): opt-in import_style=modules and oneof_style=discriminated for TS generators#198
hishamank wants to merge 4 commits into
mainfrom
feat/ts-import-style-modules

fix(ts): import only the error helpers a module actually uses

30482a9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 30, 2026 in 1s

4.09% (+0.76%) compared to ad6a1b5

View this Pull Request on Codecov

4.09% (+0.76%) compared to ad6a1b5

Details

Codecov Report

❌ Patch coverage is 26.50273% with 269 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.09%. Comparing base (ad6a1b5) to head (30482a9).

Files with missing lines Patch % Lines
internal/tscommon/modules.go 0.00% 82 Missing ⚠️
internal/tscommon/types.go 0.00% 66 Missing ⚠️
internal/tscommon/imports.go 66.34% 33 Missing and 2 partials ⚠️
internal/tsservergen/modules.go 0.00% 29 Missing ⚠️
internal/tsclientgen/modules.go 0.00% 26 Missing ⚠️
internal/tsservergen/generator.go 0.00% 18 Missing ⚠️
internal/tsclientgen/generator.go 0.00% 11 Missing ⚠️
internal/tscommon/config.go 93.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #198      +/-   ##
========================================
+ Coverage   3.32%   4.09%   +0.76%     
========================================
  Files         62      67       +5     
  Lines      10966   11290     +324     
========================================
+ Hits         365     462      +97     
- Misses     10595   10819     +224     
- Partials       6       9       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.