Open
Conversation
I don't know how well this will play with other mods trying to add flowers, but that's something to worry about later
This crashes, and I think it's because the registry doesn't exist on the client? No idea if that's actually the case, but it's getting late and I want to sleep.
IT's still not right, but at least it's getting easier to test this mod
This also collapses everything down to a single item type, using components to do the rest. This might be a bad idea, but it was easier to keep the one block item than trying to do the multiple items mapping to one block that the previous version of the mod had.
I have no idea what I'm doing, and it shows. This work is currently frustrating, but I at least have something appearing on the screen even though I'm not thinking about it too hard. My attempts with actual models aren't working because the models themselves either haven't loaded (likely) or I'm trying to get them the wring way (also likely).
Why is half of the work I've done datagen related? That question is rhetorical, I know exactly why.
This is a big giant ugly megacommit of doom. There is a lot that happened to make it, including replacing the Fabric model loading API with a thinner slice. I also switched to Intellij for development during this (was previously using VS Code) and there are also a lot of inspections changes that came along too.
This will likely need to move as I need to re-create all of the registering to support NeoForge
I don't think this will have much effect, but probably good to do
I finally happened to find NeoForge's standalone model loading after all this time. The mod now loads on NeoForge, but none of the resources are there. Like, none of them whatsoever.
I have no idea what actually changed here, but whatever it is it now works and that's good enough for me.
This started by me grouping the mixins, but quickly turned into the renaming I've been wanting to do for a while
By the magic of implementing two of them...
I believe this is the last one from all of the refactoring
The advantage of having not released the mod is that I can rename things whenever I like!
The BlockState parameter can be calculated, so doesn't need to be passed around.
It still relies on the fabric.mod.json to be there when importing, but it will now generate a neoforge.mods.toml file.
For probably legacy reasons, NeoForge updates block particles immediately after creating them, which meant that the original mixin didn't work.
What's better than writing datagen? Abstracting away the datagen! I don't know why I like messing with the datagen code so much.
Hopefully this works, I can't test the release workflow until I actually release.
Deploying tiny-flowers-generator with
|
| Latest commit: |
dc89a0f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://830c38c3.tiny-flowers-generator.pages.dev |
| Branch Preview URL: | https://auto-update-26-1-2.tiny-flowers-generator.pages.dev |
002182d to
dc89a0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains automated updates from the update-minecraft-version workflow.
Updates
26.1.2(Compatible:~26.1.2)250.146.0+26.1.218.0.0-alpha.80.19.2Remember to check!