Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

### Fixed

- Fixed `NullPointerException` when plugin descriptor is not available during startup
- Fixed `NoClassDefFoundError` in `CsvEditorSettings`
- Fixed `java.lang.Throwable: ... Class initialization must not depend on services` by removing service access from class initializers and constructors
- Fixed a `PluginException` (caused by `java.lang.IllegalArgumentException`) that occurred during early plugin initialization
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,13 @@ public void run(@NotNull ProgressIndicator progressIndicator) {
doAsyncProjectMaintenance(project);

NotificationGroup notificationGroup = NotificationGroupManager.getInstance().getNotificationGroup("net.seesharpsoft.intellij.plugins.csv");
if (notificationGroup == null || CsvEditorSettings.getInstance().checkCurrentPluginVersion(CsvPluginManager.getVersion())) {
String version = CsvPluginManager.getVersion();
if (version.isEmpty() || notificationGroup == null || CsvEditorSettings.getInstance().checkCurrentPluginVersion(version)) {
return continuation;
}

Notification notification = notificationGroup.createNotification(
"CSV Editor " + CsvPluginManager.getVersion() + " - Change Notes",
"CSV Editor " + version + " - Change Notes",
CsvPluginManager.getChangeNotes() +
"<p>You can always <b>customize plugin settings</b> to your likings (shortcuts below)!</p>" +
"<br>" +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ public static IdeaPluginDescriptor getPluginDescriptor() {
}

public static String getVersion() {
return getPluginDescriptor().getVersion();
IdeaPluginDescriptor descriptor = getPluginDescriptor();
return descriptor == null ? "" : descriptor.getVersion();
}

public static String getChangeNotes() {
return getPluginDescriptor().getChangeNotes();
IdeaPluginDescriptor descriptor = getPluginDescriptor();
return descriptor == null ? "" : descriptor.getChangeNotes();
}

private CsvPluginManager() {
Expand Down
Loading