Conversation
yitzhakc
requested changes
Jan 27, 2026
| Search or Search Results page. | ||
| """ | ||
| search_params = get_search_params(request.GET) | ||
| if request.active_module == VOICES_MODULE and search_params["query"]: |
Contributor
There was a problem hiding this comment.
Do we have any unit tests for this feature? It feels like we should have been able to catch this.. (Although I'm still not 100% sure what the problem is)
| @@ -941,6 +941,20 @@ def search(request): | |||
| Search or Search Results page. | |||
Contributor
There was a problem hiding this comment.
Please add docstring to explain what is happening now, it is non-trivial!
Contributor
YishaiGlasner
left a comment
YishaiGlasner
left a comment
There was a problem hiding this comment.
This is not a bug fix but new feature, and it can problematic.
Think about a case i want to search for genesis in voices...
Also, when typing a ref in library you have in autocompletions the option to search or to go to the book, topic etc. Here also you should add this to autocomletions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redirect Voices search for valid refs to sheets-with-ref
Added a server-side redirect in voices /search when q is a valid ref, preserving other query params and sending users to /sheets-with-ref/. (views.py)
Added a client-side guard in voices search flow to redirect immediately on valid refs. (ReaderApp.jsx)