feat: branched based staging and prod environments#3144
Conversation
🧪 CI InsightsHere's what we observed from your CI run for bb65d41. 🟢 All jobs passed!But CI Insights is watching 👀 |
|
1,2 you suggested switching master to staging release channel, but it seems like we agreed it would stay base channel, so I am not sure where the first two comments are coming from. 3 I have never heard of semantic caring about the list ordering of branches before and am fairly certain we have the stable branch listed first in all the other releaserc files. 4 Added timeouts. 5 The kustomization object is in the infra repo, having it inside the folder that it itself references would not make sense in this for this workflow 6 - we will probably remove continuous.yaml from master? It doesn't make sense to build the images twice in any case. @akiva10b Thoughts on testing in staging env? 7 - we will remove this pipeline as soon as the static deploy is in place, but I have fixed for now 8 - 11, all of these are set as per the current prod deploy file 13, this is a good suggestion, but it would need duplication of a lot of other dev config In terms of nitpicks, the domains block being missing from prod should be the highest priortiy blocker if it was actually missing, which it is not... |
[sc-42373]
Description
A brief description of the PR
Code Changes
The following changes were made to the files below
Notes
Any additional notes go here