Skip to content

feat: branched based staging and prod environments#3144

Merged
yodem merged 3 commits intopreprodfrom
branch-based-envs
Mar 19, 2026
Merged

feat: branched based staging and prod environments#3144
yodem merged 3 commits intopreprodfrom
branch-based-envs

Conversation

@BrendanGalloway
Copy link
Contributor

@BrendanGalloway BrendanGalloway commented Mar 11, 2026

[sc-42373]

Description

A brief description of the PR

Code Changes

The following changes were made to the files below

Notes

Any additional notes go here

@mergify
Copy link

mergify bot commented Mar 11, 2026

🧪 CI Insights

Here's what we observed from your CI run for bb65d41.

🟢 All jobs passed!

But CI Insights is watching 👀

yodem

This comment was marked as outdated.

@BrendanGalloway
Copy link
Contributor Author

1,2 you suggested switching master to staging release channel, but it seems like we agreed it would stay base channel, so I am not sure where the first two comments are coming from.

3 I have never heard of semantic caring about the list ordering of branches before and am fairly certain we have the stable branch listed first in all the other releaserc files.

4 Added timeouts.

5 The kustomization object is in the infra repo, having it inside the folder that it itself references would not make sense in this for this workflow

6 - we will probably remove continuous.yaml from master? It doesn't make sense to build the images twice in any case. @akiva10b Thoughts on testing in staging env?

7 - we will remove this pipeline as soon as the static deploy is in place, but I have fixed for now

8 - 11, all of these are set as per the current prod deploy file

13, this is a good suggestion, but it would need duplication of a lot of other dev config

In terms of nitpicks, the domains block being missing from prod should be the highest priortiy blocker if it was actually missing, which it is not...

@yodem yodem self-requested a review March 11, 2026 12:27
@yodem yodem merged commit 83262c8 into preprod Mar 19, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants