Skip to content

chore: "false" is truthy#3150

Merged
yitzhakc merged 2 commits intomasterfrom
bug/sc-42589/-chatbot-mode-closed-mode-does-not-persist
Mar 19, 2026
Merged

chore: "false" is truthy#3150
yitzhakc merged 2 commits intomasterfrom
bug/sc-42589/-chatbot-mode-closed-mode-does-not-persist

Conversation

@stevekaplan123
Copy link
Contributor

@stevekaplan123 stevekaplan123 commented Mar 16, 2026

Description

Passing props to svelte turns them into strings and "false" is evaluated as true. However, there's no need to pass 'default-open' at all since the prop defaults to false in svelte. Therefore, I simply removed the line that passed 'default-open'.

@mergify
Copy link

mergify bot commented Mar 16, 2026

🧪 CI Insights

Here's what we observed from your CI run for 49c5b7c.

🟢 All jobs passed!

But CI Insights is watching 👀

dcschreiber
dcschreiber previously approved these changes Mar 17, 2026
@stevekaplan123 stevekaplan123 added this pull request to the merge queue Mar 17, 2026
@stevekaplan123 stevekaplan123 removed this pull request from the merge queue due to a manual request Mar 17, 2026
@yitzhakc yitzhakc merged commit 77c5172 into master Mar 19, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants