Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the chat UI’s scroll behavior to rely on Svelte’s DOM-flush lifecycle (tick()) instead of a setTimeout delay, and introduces a new scroll mode that targets the start of the latest assistant response.
Changes:
- Replace
setTimeout(..., 50)-based scrolling withawait tick()inscrollToBottom(). - Add
scrollToResponseStart()and switch post-response scrolling to align the latest assistant message at the top of the message list. - Stop triggering
scrollToBottom()during streaming progress updates.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
497
to
500
| messages = [...messages, assistantMessage]; | ||
| saveMessagesToStorage(); | ||
| scrollToBottom(); | ||
| scrollToResponseStart(); | ||
yitzhakc
approved these changes
Mar 19, 2026
stevekaplan123
deleted the
feature/sc-42706/responses-should-enter-the-message-canvas
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the chat UI’s scroll behavior to scroll to the start of the latest LA response rather than scrolling to the bottom. Essential to implementing this is relying on Svelte’s DOM-flush lifecycle (
tick()) instead of asetTimeoutdelay.Changes:
setTimeout(..., 50)-based scrolling withawait tick()inscrollToBottom().tickis a built-in Svelte function that returns a promise when the DOM lifecycle has been finished. That way we don't have to guess 50 seconds and can scroll once svelte is finished updating the DOM with the new assistant message.scrollToResponseStart()and switch post-response scrolling to align the latest assistant message at the top of the message list.