Open
Conversation
|
The preview deployment for sefaria/ai-chatbot:server is ready. 🟢 Open app | Open Build Logs | Open Application Logs Last updated at: 2026-03-19 08:20:02 CET |
Comment on lines
+147
to
151
| if (savedUI?.isOpen !== undefined) { | ||
| isOpen = savedUI.isOpen; | ||
| } else if (defaultOpen) { | ||
| isOpen = true; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| isOpen = savedUI?.isOpen ?? defaultOpen; |
edit - it shows only l147, but the idea is to replace l147-151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the chatbot's default state would be closed (which is wrong) and once the user opened, our logic is wrong so that even after the user closes it, refreshing the page opens up the chatbot.
Code Changes
Updates the
<lc-chatbot>widget’s initial open/closed state logic so that persisted UI state from localStorage is respected over thedefault-openattribute, addressing incorrect “default open” behavior across reloads. Moreover, the default value for default-open is now true.